On Thu, Nov 03, 2005 at 03:44:55PM +0100, Sebastian Werner wrote: > Nice patch as I can see. There are some qooxdoo conventions which you > seem to already have coded like quite good. > > One problem I have with your patch. The QxFieldSet uses a QxAtom to > display a text/icon combination for the legend. You seem to create an > additional checkbox in your code and place it before the atom. I think > this is not a good idea. If you have a look at QxCheckBox you will see > that it inherits from QxAtom. Why not simply use a wrapper system which > inserts a QxAtom or a QxCheckBox depending if checkable in activated or > not. Or what's about another widget which inherits from QxFieldset, > named QxCheckableFieldset or something, which change the default > behaviour of creating an atom so that it use a QxCheckbox. Then you > could also remove your property "checkable". What's your opinion? In out frontend to QooxDoo we create an empty QxFieldSet. Later, we can set QxFiledSet to checkable state or not. But if first we create QxCheckableFieldSet, then we could't switch it to non-checkable state and contrariwise: if first we create QxFieldSet, then we could't set to checkable state.
-- mouse ------------------------------------------------------- SF.Net email is sponsored by: Tame your development challenges with Apache's Geronimo App Server. Download it for free - -and be entered to win a 42" plasma tv or your very own Sony(tm)PSP. Click here to play: http://sourceforge.net/geronimo.php _______________________________________________ Qooxdoo-devel mailing list Qooxdoo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
