Re: [qooxdoo-devel] improvements for xmlHttpRequest in renderer branch

[Dietrich Streifert]

Hello Stanislav, why is the raw Property of type TYPEOF_STRING and not TYPEOF_BOOLEAN? Shouldn't raw also be a boolean with default false? Stanislav Ievlev schrieb: On Thu, Dec 22, 2005 at 07:50:11PM +0300, Stanislav Ievlev wrote: On Thu, Dec 22, 2005 at 05:38:20PM +0100, Sebastian Werner wrote: I like the properties better, too. If there would be a patch with this I will apply it. OK, I will try it. New version patch in attach. P.S. And what about strange string "QxXmlHttpLoader._activex ? this.req.send(data) : this.req.send(data);" ;) -- With best regards Stanislav Ievlev. --- QxXmlHttpLoader.js.orig 2005-12-22 17:44:38 +0300 +++ QxXmlHttpLoader.js 2005-12-23 10:45:33 +0300 @@ -112,6 +112,8 @@ QxXmlHttpLoader.addProperty({ name : "requestMethod", type : QxConst.TYPEOF_STRING, defaultValue : "GET" }); +QxXmlHttpLoader.addProperty({ name : "async", type : QxConst.TYPEOF_BOOLEAN, defaultValue : true }); +QxXmlHttpLoader.addProperty({ name : "raw", type : QxConst.TYPEOF_STRING, defaultValue : null }); // Try to find valid Microsoft implementation of XMLHTTP if (QxXmlHttpLoader._activex) @@ -217,7 +219,7 @@ if ( method == "GET" ) url = "" - this.req.open(method, url, true); + this.req.open(method, url, this.getAsync()); // apply request headers to the request object // @@ -228,7 +230,7 @@ // method var data = "" if ( method == "POST" ) - data = "" + data = "" return QxXmlHttpLoader._activex ? this.req.send(data) : this.req.send(data); } -- Mit freundlichen Grüßen Dietrich Streifert Visionet GmbH