fixed in CVS.
Sebastian
Ulrich Schreiner schrieb:
this one?
Sebastian Werner wrote:
What's about a patch against the current HEAD? Thanks.
Sebastian
Ulrich Schreiner schrieb:
hi,
QxCommand get's a "vShortcut" as it's first parameter. if you set
this to "null" or QxConst.CORE_EMPTY then the constructor-code
if (QxUtil.isValid(vShortcut)) {
this.setShortcut(vShortcut);
};
does not set the shortcut, so the instancevariable "_shortcutParts"
is null (or not defined)
when pressing a key the method "_matchesKeyEvent" is called and the
first few lines
if (!(QxUtil.isValid(this.getShortcut()) ||
QxUtil.isValid(this.getKeyCode()))) {
return false;
};
return true, because i gave a valid keycode to the QxCommand. but the
next line crashes
if ((this._shortcutParts.shift && !e.getShiftKey()) ||
(this._shortcutParts.ctrl && !e.getCtrlKey()) ||
(this._shortcutParts.alt && !e.getAltKey())) {
return false;
};
because "_shortcutParts" is null.
i changed my code to initialize "_shortcutParts" in the constructor
with "{}" and in the "_modifyShortcut" also to never set it to null
perhaps someone can fix this?
cu
</usc>
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting
language
that extends applications into web and mobile media. Attend the live
webcast
and join the prime developer group breaking into this new coding
territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Qooxdoo-devel mailing list
Qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting
language
that extends applications into web and mobile media. Attend the live
webcast
and join the prime developer group breaking into this new coding
territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Qooxdoo-devel mailing list
Qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------
Index: QxCommand.js
===================================================================
RCS file: /cvsroot/qooxdoo/qooxdoo/source/script/gui/QxCommand.js,v
retrieving revision 1.1.2.8
diff -r1.1.2.8 QxCommand.js
48a49,50
this._shortcutParts = {};
91a94,96
// build a hash with active keys
this._shortcutParts = {};
98,100d102
< // build a hash with active keys
< this._shortcutParts = {};
<
105,108d106
< else
< {
< this._shortcutParts = null;
< };
-------------------------------------------------------
This SF.Net email is sponsored by xPML, a groundbreaking scripting language
that extends applications into web and mobile media. Attend the live webcast
and join the prime developer group breaking into this new coding territory!
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=110944&bid=241720&dat=121642
_______________________________________________
Qooxdoo-devel mailing list
Qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
