Sebastian Werner <[EMAIL PROTECTED]> writes: > Hi Derrel,
> first I must say, that this is a great work. I really like to see such user > contributions. Thank you! > Just some comments: > > * Keyboard-navigation seems to be buggy Ok, I'll look at it. I'm not sure why it should be any different than the original tree code since I don't think I modified anything with the events which handle keyboard navigation, but I'll see what I broke. > * There is no example without a root-node -> would be nice TreeFullControl_2.html and TreeFullControl_3.html have a checkbox for hiding the root node. > * To have the ability to define the "TreeRowStructure" is nice, but I think > this need only be done once for a whole tree. This would also reduce the > number of additional objects compared to the old tree. You're probably right but I should think about this a bit. Currently, you specify which icons you want to use for a particular row via this object, but there's likely an alternative method of doing that. > * The *Simple classes I think is not a good choice. I would better like if > the classes internally jump to default row specification if none given. This > would mean to remove the *Simple classes at all. Ah, that's good. Initially, the *Simple classes had the names of the original tree class, so as to be backward compatible on the assumption that this class was *replacing* the old class. Since that's not the case, you're right, there's no need for the *Simple ones. I'll work on these things over the next bunch of days. Cheers, Derrell _______________________________________________ Qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
