Sebastian Werner <[EMAIL PROTECTED]> writes:
> #1:
> ---------
>
> Are you sure you want to change this:
> + var vText = this.getIframeTextContent();
> +
> switch(this.getResponseType())
> {
> case qx.constant.Mime.TEXT:
> - return this.getIframeTextContent();
> + return vText;
> break;
>
> case qx.constant.Mime.HTML:
> - return this.getIframeHtmlContent();
> + return vText;
> break;
>
> What's the reason to return the text for mimeType HTML?
Sebastian, thanks for your comments!
There is no reason. It's a bug. Good catch. In XmlHttpTransport, the two
are handled by the same function and I missed the fact that it calls a
different function in IframeTransport.
> #2:
> ---------
>
> + * Derrell Lipman
>
> What's about to also add a contact email addresse to the source files, like
> the other authors handle this?
Paranoia. I already get on the order of *8000-10,000* spam messages *per day*
and I'd prefer not to be getting more. :-( Miners can as easily decipher "user
at address" as "[EMAIL PROTECTED]" so the wording change doesn't help much. If
you
really want it, I'll add it.
> #3:
> ---------
>
> Could you rename both JSON and RPC javascript files and class names to
> CamelCase Style. Results in JSON => Json, RPC => Rpc. we have also made this
> decision in other areas and I think it was a good choice.
NP.
> #4:
> ---------
>
> Why:
> var handleRequestFinished = function() {
>
> and not just:
> function handleRequestFinished()
>
> should be also local and not global in this case.
Maybe I have a misunderstanding about basic javascript. It's not a language
which I yet consider myself an expert, and I could certainly still have
misconceptions. That function is declared and the assignment is made inside
of the function qx.Proto._callInternal. My understanding is that using "var"
should create a variable local to qx.io.remote.RPC._callInternal(), completely
equivalent (as far as scope) to the method you describe. Is my understanding
incorrect?
That not withstanding, I had originally tried it the way you suggest but I
couldn't get it to work; I kept getting javascript errors. At the time, I
thought it was just my not-quite-complete javascript knowledge, but now that I
look at it again, I see that the script that creates qooxdoo.js is generating
invalid code for the embedded function:
...
functionhandleRequestFinished(){if(async){handler(result,ex,id);
}};
...
Note that the space between "function" and "handleRequestFinished()" is
missing. I haven't yet learned about how qooxdoo.js is generated, so for the
moment, I'll leave the fix to this problem up to the "experts". Once fixed,
if there's a valid technical or philosophical reason to use the method you
describe rather than what I'm doing, I'll gladly change it.
Thanks for spending the time looking at this and commenting!
Cheers,
Derrell
_______________________________________________
Qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
