Derrell Lipman schrieb: > On 8/5/07, *bibliograph* <[EMAIL PROTECTED] > <mailto:[EMAIL PROTECTED]>> wrote: > > Hi Derrell, > > here is another patch that I would like to ask you to integrate. It is > not a good idea to suppress errors during the inclusion of the service > class file, since this breaks manual error handling. My patch > keeps the > current behaviour but allows error handling. > > > Hi Christian, > > I'll look at your various messages in depth later, but I have a > comment on this one... It's generally a poor idea to EVER check > whether you "can" do something, followed by doing it if you "can". > This leads to race conditions. It's much better to try to actually do > it, and check for errors that occurred. In fact, I should change the > inclusion of global_settings.php to do that too: rather then checking > whether it exists and then requiring it, just include it > unconditionally (and in this case, ignore a "does not exist" error). >
Hi Derrell, I am not a trained software developer, so I do not know this principle, but I am happy to learn. However, error suppression in a "include" statement also suppresses errors that are thrown during the inclusion (such as double declaration of classes etc.). These errors should be adequately handled and not just ignored. However way you are designing it correctly, you need to be able to distinguish between the condition "file is not present" and "included files have errors". > Granted we're talking server-side stuff that only changes upon > developer actions, but it's still a principle that's worth ALWAYS > following. > > I'll look at your error trapping stuff to figure out what you're doing > "manually". Since it's already returning a ServiceNotFound error, I > don't know what else you'd want to do, but since you're requesting > this, there must be something. :-) PHP errors are presently not caught by your server code - this is what I am proposing to integrate through the "manual" error catching, which then needs to be able to also catch errors thrown during file inclusion. Cheers, Christian > > BTW, I like your idea about providing a manipulation hook for the > return value. I'll look in more detail at what you suggested later. > > Cheers, > > Derrell > > ------------------------------------------------------------------------ > > ------------------------------------------------------------------------- > This SF.net email is sponsored by: Splunk Inc. > Still grepping through log files to find problems? Stop. > Now Search log events and configuration files using AJAX and a browser. > Download your FREE copy of Splunk now >> http://get.splunk.com/ > ------------------------------------------------------------------------ > > _______________________________________________ > qooxdoo-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel > ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
