On 10/4/07, bibliograph <[EMAIL PROTECTED]> wrote: > Hi, > > I would like to propose two enhancements for the JSON-RPC PHP backend > and would write the patch for them if agreed. Both enhancements would > have no side effects and be completely backwards-compatible. > > 1) flexible class- and method prefixes > > Current state: At the moment, the prefix for accessible classes is > "class_" and for methods is "method_". > > Goal of enhancement: I would like to be able to change this into > "public_" and "public_" since I find it of little informative value > (since it is redundant to call a class a "class" and a method a "method"). > > Solution: I propose to define two constants with the names of the > prefixes which can be overridden in "global_settings.php". > > 2) fully qualified class names > > Current state: At the moment, a PHP class in > "services/foo/bar/myclass.php" has to be called "class_myclass", the > same as a class placed in "services/zoo/zar/myclass.php". > > Problem: You cannot use both classes at the same time. Of course, you > can rename them, but if you want to use a nice package-like system > mirroring the classes of the client, you are out of luck > > Goal of enhancement: You should be able to call your classes like so: > "services/foo/bar/myclass.php" => class class_foo_bar_myclass {} > "services/zoo/zar/myclass.php" => class class_zoo_zar_myclass {} > (or, if combined with enhancement 1, class public_foo_bar_myclass {} etc.) > > Solution: in the index.php of the backend, both versions of the > classname (class_myclass and class_foo_bar_myclass) are tried. > > I'd be happy to contribute a patch.
Hi Christian, I see no problem in principle with either of these changes, and the changes look fairly trivial. Feel free to post a patch and I'll review it. I think you intend to implement it this way anyway, but I would prefer that the backward-compatibility name is tried first, with your modified names tried if the original name is not found. Cheers, Derrell ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ _______________________________________________ qooxdoo-devel mailing list qooxdoo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel