Hi Helder, we are finally back to work, after the AjaxWorld and easter :-). I'm just taking a closer look at your patches. This is the kind of feedback I really like. You give good description of the issue and separate patches to solve them. Good work! > http://www.nabble.com/file/p15950710/Pane-InvalidMarkup-PerformanceImprovement.patch > Pane-InvalidMarkup-PerformanceImprovement.patch > I have applied this one to trunk and legacy_0_7_x.
> I had noticed some time ago that a few invalid "font-family" and such errors > were issued in Firefox's Error Console but I though it had to do with some > theming issue or such. I tried to isolate the issue and the results were not > what I had in mind. > > Reproduces: > Always > > Steps to reproduce: > 1. Open Firefox's Error Console (in Tools menu); > 2. Open "Table 1" of Demo Browser's examples; > 3. Slowly scroll to the last line (using the scroll arrows); > 4. Slowly scroll up; > 5. Repeat 3 and 4 a few times; > 6. Quickly scroll down (dragging the scrollbar); > 7. Quickly scroll up; > 8. Repeat 6 and 7 a few times. > > Expected results: > Scroll happens. No errors are shown. > > Actual results: > In steps 3 to 5, CSS errors are shown in Error Console every time the last > table line is shown; > In steps 6 to 8, when scroll is very fast similar CSS errors are shown. > Scroll behavior feel has small pauses. > > Additional notes: > This was hunted down to pane code which inserted invalid CSS code (unescaped > apostrophes). Additional inspection made realize that "font-size" and > "font-family" were redundant as .qooxdoo-* CSS classes already take care of > default look, so I removed (commented) these lines to further improve > performance. The small pauses experienced in Firefox were probably due to > the invalid markup inserted and seem to be fixed. :-) > > > http://www.nabble.com/file/p15950710/Abstract-UserSelect-CoherencyImproved.patch > Abstract-UserSelect-CoherencyImproved.patch > For table, text selection seems to be fixed in Opera 9.26 (in Opera 9.5 the > changes aren't effective though). The change may also help further > improvements in Widget class, where is stated that «Opera currently has no > support to prohibit user selection». Coherency was also somehow improved > here (indenting, CSS code declaration). > I have applied this as well. We will have a low level method to set unselectable in qooxdoo 0.8. > > http://www.nabble.com/file/p15950710/Client-BoxSizing-RemoveCSSError.patch > Client-BoxSizing-RemoveCSSError.patch > Few "box-sizing" CSS errors were removed to further minimize error output. > Several 'box-sizing' are still shown (qooxdoo log window, demobrowser CSS, > etc.) but they can be probably be removed also by using a similar approach. > - vEngineBoxSizingAttr.push("-khtml-box-sizing"); + // KHTML-specific quirk already used above + //vEngineBoxSizingAttr.push("-khtml-box-sizing"); vEngineBoxSizingAttr.push("-webkit-box-sizing"); break; - case "mshtml": - break; - default: + // IE (http://webfx.eae.net/dhtml/boxsizing/boxsizing.html) + // Opera (http://www.css3.info/preview/box-sizing/) + vEngineBoxSizingAttr.push("box-sizing"); break; } - vEngineBoxSizingAttr.push("box-sizing"); Even if the code looks wrong it is actually right. Earlier version of webkit still used the "-khtml" prefix. This switched to the "-webkit" prefix some time ago. To keep backward compatibility we set both for webkit. Browsers are required to ignore unknown css attributes so this will not be a problem. For the same reason we always set the box sizing using the "standard" way as well. If a browser decides to drop its proprietary box-sizing attribute in favour of the standard, it won't break qooxdoo. > With these patches applied, most (all?) qooxdoo-related CSS errors seem to > be removed. Also ran few Demo Browser layout tests and such to ensure that > core behavior was left untouched. Used Firefox 2.0.0.12 (also 3.0b5pre), > Internet Explorer 7, Safari 3.0.4 beta, Opera 9.26 (also 9.50 beta). > > > Hope this helps, > > Helder Magalhães > Best Fabian -- Fabian Jakobs JavaScript Framework Developer 1&1 Internet AG Brauerstraße 48 76135 Karlsruhe Amtsgericht Montabaur HRB 6484 Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Andreas Gauger, Thomas Gottschlich, Matthias Greve, Robert Hoffmann, Markus Huhn, Achim Weiss Aufsichtsratsvorsitzender: Michael Scheeren ------------------------------------------------------------------------- This SF.net email is sponsored by: Microsoft Defy all challenges. Microsoft(R) Visual Studio 2008. http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/ _______________________________________________ qooxdoo-devel mailing list qooxdoo-devel@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
