Hello,
I am using qooxdoo 0.7.3.
Implementation of method updateHeaderCell of qx.ui.table.headerrenderer.Icon
is the following:
updateHeaderCell : function(cellInfo, cellWidget)
{
this.base(arguments, cellInfo, cellWidget);
// Set URL to icon
var img =
cellWidget.getUserData("qx_ui_table_IconHeaderCellRenderer_icon");
if (img == null)
{
img = new qx.ui.basic.Image();
cellWidget.setUserData("qx_ui_table_IconHeaderCellRenderer_icon",
img);
cellWidget.addAtBegin(img);
}
img.setSource(this.getIconUrl());
}
Are there any reasons that image object is being created and used to show
icon?
I suppose that implementation of updateHeaderCell can be simplified and look
like:
updateHeaderCell : function(cellInfo, cellWidget)
{
this.base(arguments, cellInfo, cellWidget);
// Set URL to icon
cellWidget.setIcon(this.getIconUrl());
cellWidget.setIconPosition("left");
}
Moreover, it seems that qx.ui.table.headerrenderer.Icon class is unnecessary
because qx.ui.table.headerrenderer.Default can be slightly improved to
support showing icons.
Best regards,
Denis
--
View this message in context:
http://www.nabble.com/Question-about-implementation-of-qx.ui.table.headerrenderer.Icon.updateHeaderCell-tp16560017p16560017.html
Sent from the qooxdoo-devel mailing list archive at Nabble.com.
-------------------------------------------------------------------------
This SF.net email is sponsored by the 2008 JavaOne(SM) Conference
Register now and save $200. Hurry, offer ends at 11:59 p.m.,
Monday, April 7! Use priority code J8TLD2.
http://ad.doubleclick.net/clk;198757673;13503038;p?http://java.sun.com/javaone
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
