Hi Erich,

thank you for the hint. I have fixed it in the current trunk (rev. 16909).

Best Fabian
> Hi Fabian!
>
> First thank you for discovering the Key Event - Bug in firefox as
> reported in your blog entry Key Events: A Never Ending Story
> <http://news.qooxdoo.org/?p=606>
>
> Secondly more thanks for implementing a workaround to solve the problem
> in qooxdoo.
>
> Thirdly a request:
> Please add also the keycodes for PageUp and PageDown (33, 34) in the
> workaround.
> (I use them in my application :-[ ) (like in the patch below).
>
> Erich Konicek
>
>
> Index:
> S:/entw/konrad2/qooxdoo/framework/source/class/qx/event/handler/Keyboard.js
> ===================================================================
> ---
> S:/entw/konrad2/qooxdoo/framework/source/class/qx/event/handler/Keyboard.js   
> (revision 16905)
> +++
> S:/entw/konrad2/qooxdoo/framework/source/class/qx/event/handler/Keyboard.js   
> (working copy)
> @@ -390,7 +390,7 @@
>          // "keypress" event in Firefox but as it fires keydown events we
>          // emulate these keypress events
>          // https://bugzilla.mozilla.org/show_bug.cgi?id=467513
> -        if (type === "keydown" && (keyCode == 38 || keyCode == 40))
> +        if (type === "keydown" && (keyCode == 33 || keyCode == 34 ||
> keyCode == 38 || keyCode == 40))
>          {
>            var target = domEvent.target;
>            if (target.nodeType == 1 && target.type == "text" &&
> target.tagName.toLowerCase() === "input") {
>
>
> ------------------------------------------------------------------------------
> SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
> The future of the web can't happen without you.  Join us at MIX09 to help
> pave the way to the Next Web now. Learn more and register at
> http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
> _______________________________________________
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>
>
>   


-- 
Fabian Jakobs
JavaScript Framework Developer

1&1 Internet AG
Brauerstraße 48
76135 Karlsruhe

Amtsgericht Montabaur HRB 6484

Vorstand: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Thomas 
Gottschlich, Matthias Greve, Robert Hoffmann, Markus Huhn, Oliver Mauss, Achim 
Weiss
Aufsichtsratsvorsitzender: Michael Scheeren


------------------------------------------------------------------------------
SF.Net email is Sponsored by MIX09, March 18-20, 2009 in Las Vegas, Nevada.
The future of the web can't happen without you.  Join us at MIX09 to help
pave the way to the Next Web now. Learn more and register at
http://ad.doubleclick.net/clk;208669438;13503038;i?http://2009.visitmix.com/
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to