Hi Alex, I'm having problems with my first change to the 0.3-pre branch that's probably down to my inexperience with Qx but perhaps you can help - I have a function in command/Manager which is trying to get the text node where the user's cursor is so that it can change the paragraph into a heading (for example). But whether I use this.__editorInstance.getRange() or this.__editorInstance.getFocusNode() I get the drop down of my HtmlEditor (which is derived from Widget and contains an instance of HtmlArea).
I've traced the calls in the debugger and they definitely get through to htmlarea.__iframe.getDocument().getSelection() so I'm stumped. Any ideas? I'm using IE8 and Qx0.8.1. John -----Original Message----- From: Alexander Back [mailto:[email protected]] Sent: 26 February 2009 17:21 To: qooxdoo Development Subject: Re: [qooxdoo-devel] HtmlArea toolbars and updates for 0.8.1 Hi John, John Spackman wrote: >> The "0.3-pre" branch should be up-to-date with the current qooxdoo >> trunk. Did you encounter problems using this branch? > > Oh damn - I read the comment on 0.4-pre that said that it was for bug fixes > and assumed that it would have fixes newer than 0.3-pre. The version numbers of the contributions *can* be confusing at first sight. Always check the "Manifest.json" / "Manifest.js" file to gather informations about the compatibility. >> What do you think about creating a new contrib project called >> "HtmlEditor" and add your code there. This project can use the HtmlArea >> itself as contrib so we do not have to double the codebase. > > Yep, that was my intention - I remember the discussion we had last year and > the general preference to keep it separate; Andreas has added me to the > qooxdoo-contrib project on SF and I'll be uploading the HtmlEditor later on. Nice to hear that. > I wanted to tactfully talk to you about accepting some changes to HtmlArea - > I've had to make these changes: > - Added support for setting paragraph styles so that the HtmlEditor can have > a drop down to switch between paragraph/h1/h2/etc > - Fixed references to private members in HtmlArea from command/Manager and > command/UndoManager > - Added a public API for getting the current selection and range Bugfixes/Improvments are always welcome. I guess the best thing would be if you just send them over to me and I'll have a look. > I should be able to pull out my changes fairly easily and re-apply them to > 0.3-pre - would you be happy for me to email a patch script and/or commit to > SVN (perhaps a separate branch?) Yes, just send your changes to me to review them. If everything is okay for me you can commit them to the SVN. A separate branch is not needed for this, I think. cheers, Alex ---------------------------------------------------------------------------- -- Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel ------------------------------------------------------------------------------ Open Source Business Conference (OSBC), March 24-25, 2009, San Francisco, CA -OSBC tackles the biggest issue in open source: Open Sourcing the Enterprise -Strategies to boost innovation and cut costs with open source participation -Receive a $600 discount off the registration fee with the source code: SFAD http://p.sf.net/sfu/XcvMzF8H _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
