Hiho,
it works - thanks! Sure. Unit test aren't a bad habit, but they may not find
every issue ;-)
Greets,
Cajus
Martin Wittemann schrieb:
> Hi,
>
> im back again with a fix to your problem (commited in the trunk). :)
> But here is the patch for you.
>
> 1.
> this.getTarget().resetRoot();
> in line 399 (above oldRoot.destroy();) in the __buildTree method.
>
> 2.
> // only build up a new tree if a model is given
> if (this.getModel() != null) {
> in line 402 (above // add a new root node) in the __buildTree method.
>
> 3.
> }
> in line 409 (below this.__updateTreeChildren(rootNode,
> this.getModel());) in the __buildTree method.
>
> That should do the job. Thanks again for reporting the bug. This shows
> to me that more than 200 unit tests for the data binding does not say
> that its free of bugs. ;)
>
> Cheers,
> Martin
>
> Am 08.04.2009 um 09:13 schrieb Cajus Pollmeier:
>
>> Martin Wittemann schrieb:
>>> Hi Cajus,
>>>
>>> you can path the 0.8.2 tree controller yourself like i did in the
>>> trunk yesterday. You have to add two snippets:
>>>
>>> 1.
>>> this.__childrenRef = {};
>>> in line 505 (below root.destroy();) in the __emptyTarget method.
>>>
>>> 2.
>>> if (value == null || value.createItem == null) {
>>> return;
>>> }
>>> in line 702 (above this._startSelectionModification();) in the
>>> _setCreateItem method.
>>>
>>> That should help and you should still have the same behavior as you
>>> had before.
>>>
>>> Best,
>>> Martin
>>>
>>> P.S. Thanks for the flowers. We do our best. :)
>> Hehe. No problem. I've used the Tree.js including your patch and it
>> works fine. Thanks.
>>
>> Just found another issue: you cannot reset the treeController model
>> without getting errors. Just call treeController.resetModel() in my
>> example.
>>
>> Cheers,
>> Cajus
>>
>> ------------------------------------------------------------------------------
>> This SF.net email is sponsored by:
>> High Quality Requirements in a Collaborative Environment.
>> Download a free trial of Rational Requirements Composer Now!
>> http://p.sf.net/sfu/www-ibm-com
>> _______________________________________________
>> qooxdoo-devel mailing list
>> [email protected]
>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>>
>>
>
>
> ------------------------------------------------------------------------------
> This SF.net email is sponsored by:
> High Quality Requirements in a Collaborative Environment.
> Download a free trial of Rational Requirements Composer Now!
> http://p.sf.net/sfu/www-ibm-com
> _______________________________________________
> qooxdoo-devel mailing list
> [email protected]
> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
This SF.net email is sponsored by:
High Quality Requirements in a Collaborative Environment.
Download a free trial of Rational Requirements Composer Now!
http://p.sf.net/sfu/www-ibm-com
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
