On Sun, 2009-06-21 at 11:24 -0400, Derrell Lipman wrote:
> On Sun, Jun 21, 2009 at 9:24 AM, Gene Amtower <[email protected]>
> wrote:
>
> > (Upon closer inspection, I think you patched the public
> > method, which calls the protected method that I override as
> > long as the test conditions are met. Am I reading this
> > correctly?)
>
> Yes, I have preventing calling the user-provided _loadRowCount()
> method if there is already such a request in progress (i.e. the user-
> provided code has not yet called _onRowCountLoaded(). There is
> therefore no reason for _loadRowCount() to ever need to deal with it.
>
>
>
> I removed my changes from the snippet in my extended classes
> and added the proposed patch to the qx.ui.table.model.Remote
> class. I then cleared the app cache and rebuilt my app. The
> repeat calls have returned, so it doesn't appear to have
> resolved the issue. Your new code looked good to me, so I'm
> not sure why it's not blocking the repeat calls to the
> backend.
>
>
>
> Doh! A mutex that doesn't actually get set does not readily prevent
> re-entry. I was never setting __loadRowCountRequestRuning to true. :-(
>
> Please revert yesterday's patch and try this one instead.
> Alternatively, you can modify your already patched code. Just add the
> following line immediately before each of the two occurrances of
> this._loadRowCount() in qx.ui.table.model.Remote:
>
> this.__loadRowCountRequestRunning = true;
>
>
> Derrell
Yep, I missed that little detail myself. Adding those two lines
resolved the problem, although I had to make sure I called
this._rowCountLoaded() method without a parameter for a scenario where I
don't actually send the RPC request to make sure to reset the mutex and
clear the row count.
Gene
------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference!
Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
