On Thu, Jul 23, 2009 at 10:07 AM, skar <[email protected]> wrote:
> Derrell Lipman wrote: > > Ok. I'm trying to work this in spare cycles while doing other stuff, so > I'm > > going to ask you to do the grunt work of testing, to figure this out. > Sorry. > > > > Looking deeper, the XmlHttp transport only looks for response text if the > > state is "completed" so it needs fixing too. (I wonder what one would > expect > > to happen if a different transport, e.g. Iframe transport, were in use? > It > > pulls the content from the Iframe, so if the request didn't succeed, you > > wouldn't have any data there. Ok, well let's see if we can fix this for > > XmlHttp tranport anyway.) > > > > Please apply this ADDITIONAL patch and let me know if it solves the > problem. > > This is a bit more invasive, as we're now looking for response text in > > states other than "completed" so I may want to review this when I'm not > as > > harried with other things before actually applying it. I am interested in > > your testing results, however. > > > Ok, I applied both these patches. The first one went fine, while the > second one succeeded too, but gave this output: > > > patch -p2 < ../../qooxdoo/x.patch > > patching file framework/source/class/qx/io/remote/Exchange.js > > qooxdoo_sdk # patch -p2 < ../../qooxdoo/x2.patch > > patching file framework/source/class/qx/io/remote/transport/XmlHttp.js > > Hunk #1 succeeded at 631 (offset 3 lines). > > Hunk #2 succeeded at 717 (offset 3 lines). > > Hunk #3 succeeded at 739 (offset 3 lines). All right, that just means that you're not fully up-to-date from svn, but it found the right place to apply the patch anyway. > And it hit jackpot. It gave the right content on error status codes. It > passed me all the possible content/status combos I've listed for my > rails app. Guess that fixes the problem, at least for the XHR transport. > Thanks a lot for the patch. > Great. I didn't see a bug report come through yet for this. Did you create one? If not yet, please do so I have a bug number to apply the patch against after I review the consequences more carefully. Derrell
------------------------------------------------------------------------------
_______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
