thanks. :)

Am 27.07.2009 um 11:53 schrieb Florian Giesen:

Thank you, Martin!
I have tested your fix and have no error any more. You and the others from the QooXdoo team are doing a great job!

Regards, Florian
2009/7/27 Martin Wittemann <[email protected]>
Hello Florian,

thanks for the code snipped. It took me a while to reproduce the bug because it heavily depends on the content of the arrays. But the following code snippet did the job:

var data = {d:[1,2,3,4,5]}
var m = qx.data.marshal.Json.createModel(data, true);
m.getD().remove(m.getD().getItem(1));

and brought up the bug in the data array. Looks like I missed the name in the splice method of the array. I fixed it immediately and committed it with revision 19689.

Thanks for the report,
Martin

Am 25.07.2009 um 13:44 schrieb Florian Giesen:

Hello Martin,
here is my code snippet which removes selected items from a tree, i.e. the corresponding model:

// var controller is instance of qx.data.controller.Tree
// childPath: "_children"
var selection = controller.getSelection(); // type: qx.data.Array

for (var i = 0; i < selection.getLength(); i++)
{
// getParentModel(childItem) returns parent object of parameter childItem var parentItem = getParentModel(selection.getItem(i)); // type: qx.data.model

  if (parentItem)
    parentItem.get_children().remove(selection.getItem(i));
}

The first time qx.data.Array.remove() is called this way the error "data.name is undefined" in line 111 of qx.data.marshal.MEventBubbling is thrown (see my previous mail for further details).
Modifying this line

FROM: if (data.name.indexOf) {
TO:      if (data.name && data.name.indexOf) {

avoids this error for my purposes.

Regards, Florian


2009/7/25 Martin Wittemann <[email protected]>
Hello Florian,

can you perhaps supply some code snippet which makes it possible for me to reproduce the bug? Perhaps you are doing something special I didn't think of while fixing the bug. Anyway, I'll fix it as soon as I have the code snippet and can reproduce the misbehavior.

Best,
Martin


Am 24.07.2009 um 21:16 schrieb Florian Giesen:

Hello Martin,

i still have trouble with this issue, although bug #2504 is filed as fixed. It comes up when i call qx.data.Array.remove(). When the script reaches line 296 in qx.data.Array.splice()

this.fireDataEvent("changeBubble", {value: this});

you still get the error mentioned above in qx.data.marshal.MEventBubbling in method __changePropertyListener in line 111:

if (data.name.indexOf)

Regards, Florian


2009/6/24 Martin Wittemann <[email protected]>
Hello Jean-Noel,
thanks for the bugreport. I'll take care of it later the day and let you know.
Best,
Martin


Am 23.06.2009 um 19:39 schrieb Jean-Noël Rivasseau:

Ok, opened the bug:

http://bugzilla.qooxdoo.org/show_bug.cgi?id=2504

Next time I will directly report in Bugzilla bypassing the ML.

Jean-Noel

On Tue, Jun 23, 2009 at 7:18 PM, Andreas Ecker <[email protected] > wrote:
Howdy!

On Tue, 2009-06-23 at 17:21 +0200, Jean-Noël Rivasseau wrote:
> Hi,
>
> I have one object whose property is a qx.data.Array, like this:
>
> fonts: {"deferredInit": true, "event": "changeFonts", "check":
> "qx.data.Array", "apply": "_applyEventPropagation"},
>
> When I add items to the array, no problem, the
> _applyEventPropagation() is correctly called, everything is fine.
> However whenever I call removeAll() in fonts, or removeAt(0), I get
> the following error:
>
> data.name is undefined (MEventBublling.js, line 98)
>
> and nothing works. I call like this: myObject.getFonts().removeAll();
>
> This is most probably a bug, so do you want me to open an entry on
> Bugzilla? (could not find an existing bug).

Yes, please open up a bug report, as this ensures for the best workflow (I'm sure Martin will look at this asap) without cluttering the mailing
list.

Bye,

Andreas



------------------------------------------------------------------------------
Are you an open source citizen? Join us for the Open Source Bridge conference! Portland, OR, June 17-19. Two days of sessions, one day of unconference: $250.
Need another reason to go? 24-hour hacker lounge. Register today!
http://ad.doubleclick.net/clk;215844324;13503038;v?http://opensourcebridge.org
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------

_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel


------------------------------------------------------------------------------
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

------------------------------------------------------------------------------
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to