Hello Jean-Noel,
the bug is fixed. Could you please give a try?
Mostly we added unit tests for the existing code and moved the
calculation for the body element into its own subroutine. So it should
not be too hard to backport it to 0.8.2 either. :)
Best,
Martin
Am 11.08.2009 um 12:43 schrieb Jean-Noël Rivasseau:
So, how is the progress on this? Did you have a change to talk about
it yesterday, what was decided?
On Thu, Aug 6, 2009 at 7:11 PM, Jean-Noël Rivasseau
<[email protected]> wrote:
Hi Martin,
Yeah, this is a huge problem for us :)
The sooner this is fixed, the better, but it is quite complex code
so it should take quite some hours to get it correctly cleaned up
(there are a LOT of variations across different browsers).
I hope you can get this fixed sometime next week - feel free to ask
if I can do something.
Jean-Noel
On Thu, Aug 6, 2009 at 4:39 PM, Martin Wittemann <[email protected]
> wrote:
Hello Jean-Noel,
this really sound like a huge problem. I'll take care of it
tomorrow. You know, im a test lover so be sure that there will be
some unit tests at the end. ;) But I'm not the bom expert so don't
expect me to get the solution ready tomorrow. But I'll take care of
it.
Regards,
Martin
Am 06.08.2009 um 12:42 schrieb Jean-Noël Rivasseau:
Hello team,
A while ago I raised
http://bugzilla.qooxdoo.org/show_bug.cgi?id=2508
Unfortunately noone has looked at it seriously yet. Yesterday I ran
into additional problems and realized the issues are much more
serious that what I thought. Basically the whole Location code is
wrong *as soon as the body has some margins (left, top) set*.
I spent quite some time and here is what is wrong. I tested both on
0.8.2 and on today trunk, no differences (except than on today's
trunk IE was not working at all)
Firefox: wrong body location
Safari (3 & 4): correct body location, any other element location
is wrong
Opera: wrong body location
IE (7 & 8): wrong body location
I have attached a small test case to the 2508 bug, that reproduces
easily the problems.
The core of the problem is that it is complex and very browser
dependent code. But since it is so obviusly wrong when there is a
margin on the page, I really would like for a core committer to
look at the problem as soon as possible. I have to get this fixed
as soon as possible for our application, I can come up with ugly
hacks, but the correct way to do this is to spend some time looking
at the problem, write good unit tests and make sure all of them pass.
In any case I would be happy to spend time with someone from the
core team on this to fix the problem. So I hope someone will
dedicate some time for this soon.
Jean-Noel
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports
2008 30-Day
trial. Simplify your report design, integration and deployment -
and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and
focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008
30-Day
trial. Simplify your report design, integration and deployment - and
focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now.
http://p.sf.net/sfu/bobj-july_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
Let Crystal Reports handle the reporting - Free Crystal Reports 2008 30-Day
trial. Simplify your report design, integration and deployment - and focus on
what you do best, core application coding. Discover what's new with
Crystal Reports now. http://p.sf.net/sfu/bobj-july
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
