Hi Jean-Noël,
I think I have it. The attached patch should solve your issue.
Could you please verify this? If the patch is working for you, I will
also attach the patch to the original bug report.
Cheers,
Chris
Jean-Noël Rivasseau schrieb:
OK. I hope you will have some time to create the patch ;)
Another option would be to release a quick 0.8.4. It would even be
better I think - this patch alone IMHO warrants the release of a 0.8.4.
Release early, release often ^^
Cheers
Jean-Noel
On Mon, Oct 12, 2009 at 9:47 AM, Christian Schmidt
<[email protected] <mailto:[email protected]>> wrote:
Hi Jean-Noël,
I'm sorry. I couldn't find the effected lines on Friday to create the
patch. And at the moment I couldn't spend time to create a patch.
I hope
I have some time this week, but I can't promise it.
Cheers,
Chris
Christian Schmidt schrieb:
> Hi Jean-Noël,
>
> yes this should not be the problem. Could you please send me the old
> patch, that I can look what was effected.
>
> Cheers,
> Chris
>
> Jean-Noël Rivasseau schrieb:
>
>> Well, yes, if you have a bit of time I would appreciate a
working patch :)
>>
>> On Thu, Oct 8, 2009 at 5:06 PM, Christian Schmidt
>> <[email protected] <mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>> wrote:
>>
>> Hi Jean-Noël,
>>
>> the playground on
"http://demo.qooxdoo.org/current/playground/"; uses
>> always the last release, so at the moment qx 0.8.3.
>>
>> I tested the code with the current trunk (rev. 20305) and
it also
>> works
>> there. I think the patch that you are currently using has
an issue and
>> cause this behavior. But the good news it seems to be fixed
in trunk
>> (rev. 20305). Do you need help to create a new patch?
>>
>> Cheers,
>> Chris
>>
>> Jean-Noël Rivasseau schrieb:
>> > Hi, your code definitely shows it working with old
behavior. Is it
>> > trunk or 0.8.3 on the playground?
>> >
>> > I have 0.8.3 but patched with martin's diffs to get
databinding
>> > working with single selection widgets, so this may be the
cause
>> of the
>> > behavior I am seeing. it would be nice to test the same
code but
>> on trunk
>> >
>> > On Thu, Oct 8, 2009 at 2:04 PM, Christian Schmidt
>> > <[email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
>> <mailto:[email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>>> wrote:
>> >
>> > Hi Jean-Noël,
>> >
>> > could you please send me a code snippet to reproduce this
>> issue. I
>> > tried
>> > it, but I could reproduce it:
>> >
>>
http://demo.qooxdoo.org/current/playground/#%7B%22code%22%3A%20%22var%2520selectBox%2520%253D%2520new%2520qx.ui.form.SelectBox%28%29%253B%250A%250Afor%2520%28var%2520i%2520%253D%25200%253B%2520i%2520%253C%252010%253B%2520i%252B%252B%29%2520%257B%250A%2520%2520selectBox.add%28new%2520qx.ui.form.ListItem%28%2522ListItem%2522%2520%252B%2520i%29%29%253B%250A%257D%250A%250AselectBox.addListener%28%2522changeSelection%2522%252C%2520function%28e%29%2520%257B%250A%2520%2520alert%28%2522changeSelection%253A%2520%2522%2520%252B%2520e.getData%28%29%255B0%255D.getLabel%28%29%29%253B%250A%257D%252C%2520this%29%253B%250A%250A%252F%252F%2520deprecated%2520use%2520changeSelection%250AselectBox.addListener%28%2522changeValue%2522%252C%2520function%28e%29%2520%257B%250A%2520%2520alert%28%2522changeValue%253A%2520%2522%2520%252B%2520e.getData%28%29%29%253B%250A%257D%252C%2520this%29%253B%250A%250Avar%2520doc%2520%253D%2520this.getRoot%28%29%253B%250Adoc.add%28selectBox%252C%2520%257Bleft%253A%2520100%252C%2520%2520top%253A%252050%257D%29%253B%250A%22%7D
>> >
>> > The changeValue event is deprecated on 0.8.3, due to
the new
>> selection
>> > API, but it should work like on 0.8.2, if not than it is
>> > definitive a bug.
>> >
>> > Cheers,
>> > Chris
>> >
>> >
>> > Jean-Noël Rivasseau schrieb:
>> > > Hi
>> > >
>> > > On 0.8.2 with the old value API, if you registered an
>> event or data
>> > > binding on the value property, this took place only
when
>> the user
>> > > finally made its choice, eg clicked the SelectBox
ListItem.
>> > >
>> > > Now in 0.8.3 with the selection property it happens
when
>> the user
>> > > hovers with the mouse on the list items! This
behavior is
>> killing my
>> > > app. What is the proper way to use the old behavior, eg
>> selection is
>> > > changed only when the user has clicked and closed the
>> SelectBox?
>> > >
>> > > Thanks
>> > >
>> > > --
>> > > Jean-Noël Rivasseau
>> > >
>> > >
>> >
>>
------------------------------------------------------------------------
>> > >
>> > >
>> >
>>
------------------------------------------------------------------------------
>> > > Come build with us! The BlackBerry(R) Developer
Conference
>> in SF, CA
>> > > is the only developer event you need to attend this
year.
>> > Jumpstart your
>> > > developing skills, take BlackBerry mobile
applications to
>> market
>> > and stay
>> > > ahead of the curve. Join us from November 9 - 12, 2009.
>> Register
>> > now!
>> > > http://p.sf.net/sfu/devconference
>> > >
>> >
>>
------------------------------------------------------------------------
>> > >
>> > > _______________________________________________
>> > > qooxdoo-devel mailing list
>> > > [email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>
>> > <mailto:[email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>>
>> > >
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>> > >
>> >
>> >
>> > --
>> > Christian Schmidt
>> > Software Entwickler
>> >
>> > 1&1 Internet AG - Web Technologies
>> > Ernst-Frey-Straße 9 · DE-76135 Karlsruhe
>> > [email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>
>> <mailto:[email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>>
>> >
>> > Amtsgericht Montabaur / HRB 6484
>> > Vorstände: Henning Ahlert, Ralph Dommermuth, Matthias
Ehrlich,
>> > Thomas Gottschlich, Robert Hoffmann, Markus Huhn,
Hans-Henning
>> > Kettler, Dr. Oliver Mauss, Jan Oetjen
>> > Aufsichtsratsvorsitzender: Michael Scheeren
>> >
>> >
>> >
>> >
>>
------------------------------------------------------------------------------
>> > Come build with us! The BlackBerry(R) Developer
Conference
>> in SF, CA
>> > is the only developer event you need to attend this year.
>> > Jumpstart your
>> > developing skills, take BlackBerry mobile
applications to market
>> > and stay
>> > ahead of the curve. Join us from November 9 - 12, 2009.
>> Register now!
>> > http://p.sf.net/sfu/devconference
>> > _______________________________________________
>> > qooxdoo-devel mailing list
>> > [email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>
>> > <mailto:[email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>>
>> >
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>> >
>> >
>> >
>>
------------------------------------------------------------------------
>> >
>> >
>>
------------------------------------------------------------------------------
>> > Come build with us! The BlackBerry(R) Developer
Conference in SF, CA
>> > is the only developer event you need to attend this year.
>> Jumpstart your
>> > developing skills, take BlackBerry mobile applications to
market
>> and stay
>> > ahead of the curve. Join us from November 9 - 12, 2009.
Register
>> now!
>> > http://p.sf.net/sfu/devconference
>> >
>>
------------------------------------------------------------------------
>> >
>> > _______________________________________________
>> > qooxdoo-devel mailing list
>> > [email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>
>> > https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>> >
>>
>>
>> --
>> Christian Schmidt
>> Software Entwickler
>>
>> 1&1 Internet AG - Web Technologies
>> Ernst-Frey-Straße 9 · DE-76135 Karlsruhe
>> [email protected]
<mailto:[email protected]>
<mailto:[email protected]
<mailto:[email protected]>>
>>
>> Amtsgericht Montabaur / HRB 6484
>> Vorstände: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich,
>> Thomas Gottschlich, Robert Hoffmann, Markus Huhn, Hans-Henning
>> Kettler, Dr. Oliver Mauss, Jan Oetjen
>> Aufsichtsratsvorsitzender: Michael Scheeren
>>
>>
>>
>>
------------------------------------------------------------------------------
>> Come build with us! The BlackBerry(R) Developer Conference
in SF, CA
>> is the only developer event you need to attend this year.
>> Jumpstart your
>> developing skills, take BlackBerry mobile applications to
market
>> and stay
>> ahead of the curve. Join us from November 9 - 12, 2009.
Register now!
>> http://p.sf.net/sfu/devconference
>> _______________________________________________
>> qooxdoo-devel mailing list
>> [email protected]
<mailto:[email protected]>
>> <mailto:[email protected]
<mailto:[email protected]>>
>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>>
>>
------------------------------------------------------------------------
>>
>>
------------------------------------------------------------------------------
>> Come build with us! The BlackBerry(R) Developer Conference in
SF, CA
>> is the only developer event you need to attend this year.
Jumpstart your
>> developing skills, take BlackBerry mobile applications to
market and stay
>> ahead of the curve. Join us from November 9 - 12, 2009.
Register now!
>> http://p.sf.net/sfu/devconference
>>
------------------------------------------------------------------------
>>
>> _______________________________________________
>> qooxdoo-devel mailing list
>> [email protected]
<mailto:[email protected]>
>> https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
>>
>>
>
>
>
--
Christian Schmidt
Software Entwickler
1&1 Internet AG - Web Technologies
Ernst-Frey-Straße 9 · DE-76135 Karlsruhe
[email protected] <mailto:[email protected]>
Amtsgericht Montabaur / HRB 6484
Vorstände: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich,
Thomas Gottschlich, Robert Hoffmann, Markus Huhn, Hans-Henning
Kettler, Dr. Oliver Mauss, Jan Oetjen
Aufsichtsratsvorsitzender: Michael Scheeren
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year.
Jumpstart your
developing skills, take BlackBerry mobile applications to market
and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
qooxdoo-devel mailing list
[email protected]
<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
------------------------------------------------------------------------
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
--
Christian Schmidt
Software Entwickler
1&1 Internet AG - Web Technologies
Ernst-Frey-Straße 9 · DE-76135 Karlsruhe
[email protected]
Amtsgericht Montabaur / HRB 6484
Vorstände: Henning Ahlert, Ralph Dommermuth, Matthias Ehrlich, Thomas
Gottschlich, Robert Hoffmann, Markus Huhn, Hans-Henning Kettler, Dr. Oliver
Mauss, Jan Oetjen
Aufsichtsratsvorsitzender: Michael Scheeren
Index: qooxdoo/framework/source/class/qx/ui/core/MMultiSelectionHandling.js
===================================================================
--- qooxdoo/framework/source/class/qx/ui/core/MMultiSelectionHandling.js
(revision 20096)
+++ qooxdoo/framework/source/class/qx/ui/core/MMultiSelectionHandling.js
(working copy)
@@ -293,7 +293,10 @@
if (items.length === 0) {
this.resetSelection();
} else {
- this.__manager.replaceSelection(items);
+ var currentSelection = this.getSelection();
+ if (!qx.lang.Array.equals(currentSelection, items)) {
+ this.__manager.replaceSelection(items);
+ }
}
},
------------------------------------------------------------------------------
Come build with us! The BlackBerry(R) Developer Conference in SF, CA
is the only developer event you need to attend this year. Jumpstart your
developing skills, take BlackBerry mobile applications to market and stay
ahead of the curve. Join us from November 9 - 12, 2009. Register now!
http://p.sf.net/sfu/devconference
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
