Hi Greg, Yesterday Greg Beaver wrote:
> Hi, > > I found a rather serious mistake in the uploadwidget trunk code, bug is > http://bugzilla.qooxdoo.org/show_bug.cgi?id=4112 > > I mention it here because my app literally won't function without it, > and I need others to be able to download the trunk of uploadwidget. iiks ... bad ... how about this patch: * it tracks the fileSize changes too * it does not try to set the filename back to the button Index: source/class/uploadwidget/UploadField.js =================================================================== --- source/class/uploadwidget/UploadField.js (revision 20770) +++ source/class/uploadwidget/UploadField.js (working copy) @@ -149,7 +149,10 @@ */ _applyFileName : function(value, old) { - this.getChildControl('button').setFileName(value); + + // the value of the file can not be changed, + // so do not try + // this.getChildControl('button').setFileName(value); this.getChildControl('textfield').setValue(value); }, @@ -228,7 +231,8 @@ _onChangeFileName : function(e) { var value = e.getData(); - this.getChildControl('textfield').setValue(value); + this.setFileName(value); + this.setFileSize(this.getChildControl('button').getFileSize()); }, cheers tobi > > Thanks, > Greg > > ------------------------------------------------------------------------------ > Start uncovering the many advantages of virtual appliances > and start using them to simplify application deployment and > accelerate your shift to cloud computing. > http://p.sf.net/sfu/novell-sfdev2dev > _______________________________________________ > qooxdoo-devel mailing list > [email protected] > https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel > > -- Tobi Oetiker, OETIKER+PARTNER AG, Aarweg 15 CH-4600 Olten, Switzerland http://it.oetiker.ch [email protected] ++41 62 775 9902 / sb: -9900 ------------------------------------------------------------------------------ Start uncovering the many advantages of virtual appliances and start using them to simplify application deployment and accelerate your shift to cloud computing. http://p.sf.net/sfu/novell-sfdev2dev _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
