Hi Martijn, I didn't follow the whole discussion, so don't blame me if I come up with a proposal which was already proposed.
Can you please open a bug report for your contribution? This way a framework developer can review your refactorings and (if applicable) apply them to the codebase. Just link to your github fork in the bug report. Regards, Alex On Friday April 15 2011 11:00:09 Martijn Evers wrote: > Hi, > > I send this post for two reasons. 1) To ask if anyone is working on the > DateField or any other date related matter. And 2) to start a discussion > about date field refactoring and design decisions. > > Earlier on this list we talked about a problem I had with the DateField > [1]. Currently, due to the work on a project, there is a need for: date, > time and datetime fields. Qooxdoo only provides a date field (with a > very cool datechooser, kudos :-) ). However when I searched the class > hierarchy and bugzilla I saw the same problem Martin reported as bug > #3161 (DateField is no ComboBox). > > Therefore I have written an AbstractDateField and refactored the current > DateField to inherit from this class [2]. So please have a look and tell > me what you think. > > I also want to resolve bug #5007 (DateField date format is reset on > changeLocale event) and #3710 (DateField should not fire "changeValue" > after locale change, which it does because the underlying ComboBox value > changes). When these problems are resolved I can build TimeField and > DatetimeField which I need for my project. > > I hope my contribution is welcome as I enjoyed your excellent framework > for quite some time now. > > Regards, > Martijn > > [1] http://sourceforge.net/mailarchive/message.php?msg_id=27344356 > [2] https://github.com/martijn4evers/qooxdoo/commits/date-fields ------------------------------------------------------------------------------ Benefiting from Server Virtualization: Beyond Initial Workload Consolidation -- Increasing the use of server virtualization is a top priority.Virtualization can reduce costs, simplify management, and improve application availability and disaster protection. Learn more about boosting the value of server virtualization. http://p.sf.net/sfu/vmware-sfdev2dev _______________________________________________ qooxdoo-devel mailing list [email protected] https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
