"overridden" is meant in the canonical OO sense [1], in that a derived class redefines the signature of a parent class method. It says nothing about the semantics of this redefinition, whether it might enhance, extend, augment or entirely replace the semantics of the parent implementation. "overridden" is still the term that applies.

T.

[1] http://en.wikipedia.org/wiki/Method_overriding

On 12/01/2011 11:33 AM, Stefan Andersson wrote:
WIthin the code, the documentation of many functions have been labeled "// overridden" while they actually have been augmented. According to our view:

Example of overridden:
    // overridden
    _add : function(child, options) {
       ...
    },

and augmentation:
    // augmented
    _add : function(child, options) {
      this.base(arguments, child, options);
       ...
    },

Examples of where we think it has been labelled in a wrong way is: qx.ui.toolbar.ToolBar

We would change the label from "// overridden" to "// augmented" in example 2.

Do you agree?

Stefan


------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure
contains a definitive record of customers, application performance,
security threats, fraudulent activity, and more. Splunk takes this
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d


_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
All the data continuously generated in your IT infrastructure 
contains a definitive record of customers, application performance, 
security threats, fraudulent activity, and more. Splunk takes this 
data and makes sense of it. IT sense. And common sense.
http://p.sf.net/sfu/splunk-novd2d
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to