Hi Derell,
Yes, I agree.
Best regards,
Jeroen
From: Derrell Lipman [mailto:derrell.lip...@unwireduniverse.com]
Sent: Friday, February 10, 2012 3:03 PM
To: qooxdoo Development
Subject: Re: [qooxdoo-devel] Question about setCellEditorFactory in
columnmodel\Basic.js
On Fri, Feb 10, 2012 at 08:56, Jeroen Smit
<jeroen.s...@ortec.com<mailto:jeroen.s...@ortec.com>> wrote:
Hi
I looks like the header renderer is compared with this.__ editorFactory which
will never result to true.
The goal seems to be to detect that the renderer has been adjusted.
Otherwise the call to setCellEditorFactory() should probably dispose the old
value, or not?
Ah, I see where you're looking. Yes, I think you're right. It looks like the
code should be changed to this:
var oldRenderer = this.__columnDataArr[col].editorFactory;
if (oldRenderer !== this.__editorFactory) {
oldRenderer.dispose();
}
Do you agree?
Derrell
------------------------------------------------------------------------------
Virtualization & Cloud Management Using Capacity Planning
Cloud computing makes use of virtualization - but cloud computing
also focuses on allowing computing to be delivered as a service.
http://www.accelacomm.com/jaw/sfnl/114/51521223/
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
