Hi,
I filed a bug as http://bugzilla.qooxdoo.org/show_bug.cgi?id=6417 with
description "Tab order issue on widgets without property tabIndex set".
Best regards,
Jeroen
From: Dietrich Streifert [mailto:dietrich.streif...@googlemail.com]
Sent: Friday, July 20, 2012 1:01 PM
To: qooxdoo Development
Subject: Re: [qooxdoo-devel] Tab order issue on widgets without property
tabIndex set
Hello Martin, Jeroen,
did this made it into bugzilla?
I've hit the same problem and Jeroens change to FocusHandler.__compareTabOrder
fixed it as described.
Regards.
Dietrich.
Am 15.05.2012 10:07, schrieb Martin Wittemann:
Hello Jeroen,
I am using Qx v 1.4.1. and I ran into a an issue around "tabbing" through
controls as this is implemented in FocusHandler.js. I do not set the tabIndex
explicitely on widgets and therefore the code falls back to the position and
eventually the Z-order.
The code marked by the comment "// Sort-Check #2: Top-Position" doesn't always
work for me because it checks on the top of widgets to exactly match:
// Sort-Check #2: Top-Position
if (loc1.top != loc2.top) {
return loc1.top - loc2.top;
}
This is not always the case in my layout and I still would like the behaviour
of tabbing from left to right to controls. As an example of such a layout the
following "example" with a checkbox in front of a control to implement optional
behaviour for the value of the actual control:
______________
X | some control |
---------------------
When in the control and pressing SHIFT + TAB I expect to end up with a checkbox
having focus but that is not the case.
I tested with a slight adjustment of the code in FocusHandler.__compareTabOrder
like this
// Sort-Check #2: Top-Position
if (loc1.top != loc2.top) {
// Fallback for slight layout issues, e.g. the top of two controls
// differs by a (few) pixel(s)
if ((loc2.bottom < loc1.top) || (loc2.top > loc1.bottom)) {
// loc2 does not have an overlap in vertical coordinates otherwise
// we fallback to the diff on "left"
return loc1.top - loc2.top;
}
}
Looking at an overlop in the vertical position of widgets rather than an exact
match.
My question is:
- What do you think of this idea?
I totally agree with you and the expected behavior. Additionally, you suggested
solution sounds like a good approach to tackle that problem.
- Is this something that could be adjusted/patched in future versions?
Sure, go ahead and open up a bug report at out bugzilla [1]. You can put in
your code as well which will help a lot including that feature. If you are
familiar with git and github, feel free to create a pull request for that
feature. :)
Thanks,
Martin
[1] http://bugzilla.qooxdoo.org/
This body part will be downloaded on demand.
This body part will be downloaded on demand.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
