Hey,
congratulation on your success. Did you write a patch or did you change the
code of the framework? With it having in a separate patch file, you can still
use the regular qooxdoo checkout and don't have to act on framework updates.
Still, thats something we could improve in the framework so you could supply
your code within a bug report. :)
Regards,
Martin
Am 28.09.2012 um 21:02 schrieb Richard Suematsu
<[email protected]<mailto:[email protected]>>:
Hey Martin,
Strike my previous message. What you said sparked an idea. I figure out the
problem was the setData() call at the bottom of the setState function in
SimpleTreeDataModel.js. When I commented that out, and manually called
tree.getDataModel.setData() after all my updates, it was fast.
So in the end I modified MNode.js to add a delayRendering flag at the end of
nodeSetOpened:
nodeSetOpened : function(nodeReference, b, delayRendering)
and passed it through till it got to the setState call. I don’t know if that’s
the right way to do it, but the only other way I could think of was to add a
property to TreeVirtual. This felt safer since I wasn’t treating it like a
state of the tree (and since I don’t really know the code).
Anyway, it’s probably hackish, but I’ll send my changes if you want it. A
1,000 node tree now expands and collapses near instantaneously in IE8, and
while Firefox always worked, it’s much faster now. Sweet.
Thanks,
Rich
From: Martin Wittemann [mailto:[email protected]<http://1und1.de>]
Sent: Friday, September 28, 2012 12:16 AM
To: qooxdoo Development
Subject: Re: [qooxdoo-devel] TreeVirtual and IE8
Hey,
a quick check at the code did not tell me much about it. But it seems like
there is no batch mode in the current implementation for setting tree nodes
open / close so every close triggers a reflow.
Sorry,
Martin
Am 25.09.2012 um 05:16 schrieb Richard Suematsu
<[email protected]<mailto:[email protected]>>:
I’m using TreeVirtual and I created buttons to expand and collapse all nodes
within the tree. Under IE8, the expand runs slow enough that I get the “Stop
running this script?” message box. Any suggestions on how to speed it up?
Collapse is quick. The slow part appears to be the nodeSetOpened call.
Here’s my code-
var treeData = tree.getDataModel().getData();
for (var i = treeData.length - 1; i > 0; i--) {
if (treeData[i]) {
tree.nodeSetOpened(treeData[i], true);
}
}
If I had to guess, it’s the screen updates between each call that is slowing it
down. Is there a way to disable it while updating all the nodes?
Thanks,
Rich
________________________________
Confidentiality Notice: This e-mail message, including any attachments, is for
the sole use of the
intended recipient(s) and may contain confidential and privileged information.
Unauthorized
review, use, disclosure or distribution is prohibited. If you are not the
addressee indicated in this
message kindly notify the sender by reply e-mail and destroy all copies of the
original message.
------------------------------------------------------------------------------
Live Security Virtual Conference
Exclusive live event will cover all the ways today's security and
threat landscape has changed and how IT managers can respond. Discussions
will include endpoint security, mobile security and the latest in malware
threats.http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/_______________________________________________
qooxdoo-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
________________________________
Confidentiality Notice: This e-mail message, including any attachments, is for
the sole use of the
intended recipient(s) and may contain confidential and privileged information.
Unauthorized
review, use, disclosure or distribution is prohibited. If you are not the
addressee indicated in this
message kindly notify the sender by reply e-mail and destroy all copies of the
original message.
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html_______________________________________________
qooxdoo-devel mailing list
[email protected]<mailto:[email protected]>
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
------------------------------------------------------------------------------
Got visibility?
Most devs has no idea what their production app looks like.
Find out how fast your code is with AppDynamics Lite.
http://ad.doubleclick.net/clk;262219671;13503038;y?
http://info.appdynamics.com/FreeJavaPerformanceDownload.html
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel
