Hey,
> As I understand null or no parameter means "default"
> 
> So
> 
> var btn = new qx.ui.form.MenuButton("Menu Button",null,  menu);  // no icon
> in current impl
> var btn = new qx.ui.form.MenuButton("Menu Button");                   //
> icon in current impl
> 
> should behave the same ( both with icon or both without icon)
> IMHO with icon.
> Otherwise 
> 
> 
>    "menubutton" : {
>      include : "button",
>      alias : "button",
> 
>      style : function(states) {
>        return {
>          icon : "decoration/arrows/down.png",
>          iconPosition : "right"
>        };
>      }
>    },
> 
> in Apperance.js is meaningless.


I don't see null as the same as undefined or simply not given.

var btn = new qx.ui.form.MenuButton("Menu Button", null,  menu);  // no icon
var btn = new qx.ui.form.MenuButton("Menu Button", undefined,  menu);  // icon

Thats the only way you can add a menu via constructor and still decide if you 
want to have the icon from the theme or no icon at all.

Regards,
Martin


------------------------------------------------------------------------------
This SF.net email is sponsored by Windows:

Build for Windows Store.

http://p.sf.net/sfu/windows-dev2dev
_______________________________________________
qooxdoo-devel mailing list
[email protected]
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to