as per a simple code review the destructur of qx.ui.window.Window should be:

   /*
*****************************************************************************
      DESTRUCTOR
*****************************************************************************
   */
   destruct : function() {
     this.removeListener("mousedown", this._onWindowMouseDown);
     this.removeListener("focusout", this._onWindowFocusOut);

     qx.core.Init.getApplication().getRoot().remove(this);
     qx.ui.core.FocusHandler.getInstance().removeRoot(this);
   }


Am 28.11.2013 12:09, schrieb Dietrich Streifert:
> Hi all,
>
> I'm currently struggling with manual disposal of qx.ui.window.Window 
> instances.
>
> I'm calling
>
>     myWindowInstance.dispose();
>
> which seems to leave the instance attached to the application root, 
> because in qx.ui.window.Window constructur the instance get 
> automatically added (from source of qx.ui.window.Window constructor:)
>
>     // Automatically add to application root.
>     qx.core.Init.getApplication().getRoot().add(this);
>
> This connection is not removed in qx.ui.window.Window as there is no 
> destruct method defined.
>
> So this sums up into two questions:
>
> 1. Shouldn't qx.ui.window.Window have a destruct method?
> 2. Should this destruct method contain 
> qx.core.Init.getApplication().getRoot().remove(this);
>
> Thank you for your help.
>
> Regards
> Dietrich
>
>
>
>
>


------------------------------------------------------------------------------
Rapidly troubleshoot problems before they affect your business. Most IT 
organizations don't have a clear picture of how application performance 
affects their revenue. With AppDynamics, you get 100% visibility into your 
Java,.NET, & PHP application. Start your 15-day FREE TRIAL of AppDynamics Pro!
http://pubads.g.doubleclick.net/gampad/clk?id=84349351&iu=/4140/ostg.clktrk
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to