Hello developers,

I ran into a problem that I think I can not fix by myself, therefore I filed
the bug 8554[1].

But apart from that real issue, I find it somewhat 'Pfui', that the method
qx.ui.form.VirtualSelectBox#__preselect() uses *protected* methods of
qx.ui.list.List (via qx.ui.form.core.VirtualDropDownList)!
<pre class='javascript'>
  // ...
  var list = this.getChildControl("dropdown").getChildControl("list");
  // ...
  var length = list._getLookupTable().length;
  // ...
  var startRow = list._reverseLookup(startIndex);
  // ... and ...
    var item = model.getItem(list._lookup(row));
</pre>

This can't be good, right?
Although it works 'cause the generator does not change names of protected
methods.


BTW: If I can -after all- work around bug 8554 without changing the framework
     code at my side, please let me know.

Thanks, regards, bye, see 'ya, whatever, ...
/Peter







[1] http://bugs.qooxdoo.org/show_bug.cgi?id=8554

Problem(s) :
------------
  A VirtualSelectBox that has a list containing groups
  fails when one tries to 'preselect' / search (via typing).

  The line...


https://github.com/qooxdoo/qooxdoo/blob/master/framework/source/class/qx/ui/form/VirtualSelectBox.js#L376

  ...fails 'cause "value" is undefined for group-items.


Work-araound(s):
----------------
  None. Due to the fact that one can not patch private members, the framework
  team has to fix this.


Proposed fix:
-------------
  A simple "value" validity check in the expression would probably
  be enough:
  <pre>
    if ( value && qx.lang.String.startsWith(...) )
  </pre>


-- 

** Unsere Veranstaltungen: 

Post-Expo in Stockholm, Halle A - Stand A10.05, 23.-25.09.2014
TIS-Hausmesse in Bocholt, 16.10.2014
3. Innovationsforum Telematik, Idstein 28.10.2014
BWVL-Tagung in K�ln, 12.-13.11.2014


------------------------------------------------------------------------------
Slashdot TV.  
Video for Nerds.  Stuff that matters.
http://tv.slashdot.org/
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to