As I understood the deprecation of SVGElement.offset* will break existing applications out there, because they currently use SVGElements in their apps.

There are a lot more locations where we would need to wrap offsetWidth and offsetHeight, e.g. target element calculations in the event handlers and element placement calculations and some basic things like the isSeeable method in qx.ui.core.Widget.

That means we would have to wrap all those .offsetWidth and .offsetHeight calls via something like qx.bom.Element.getOffsetWidth, qx.bom.Element.getOffsetHeight calls.


Am 21.03.2016 um 14:17 schrieb Dietrich Streifert:
here is just a quick fix proposal for qx.bom.eloement.Location

https://github.com/level420/qooxdoo/commit/7bdea45f23389804ddd663a7e032158f248b8466

This fixes the NaN value problem for right and bottom of Alexanders playground example in my local playground:

http://tinyurl.com/h89s2pk

@Alexander, @Matt: give it a try by replacing qx.bom.element.Location from my fork.

@all others: please have a look at that fix

Successful tested on Firefox 45, IE 11, Chrome 50, Chrome 49


Am 21.03.2016 um 12:38 schrieb Alexander Kirsanov:
I found the issue in the qx.bom.element.Location.
The issue happens in the method *get*, the qooxdoo gets the elem.offsetWidth and elem.offsetHeight, but elem could be an instance of the SVGElement. So, I suppose that the qx should check is it svgelement or not and using the element.getBBox().width instead of elem.offsetWidth in case of SVG. But I’m not sure that it is good solution.




------------------------------------------------------------------------------
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click to learn more.
http://pubads.g.doubleclick.net/gampad/clk?id=278785351&iu=/4140
_______________________________________________
qooxdoo-devel mailing list
qooxdoo-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/qooxdoo-devel

Reply via email to