Author: aconway
Date: Wed Oct 18 17:42:50 2006
New Revision: 465432
URL: http://svn.apache.org/viewvc?view=rev&rev=465432
Log:
Fixed various minor TODO issues.
Modified:
incubator/qpid/trunk/qpid/cpp/ (props changed)
incubator/qpid/trunk/qpid/cpp/Makefile
incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.cpp
incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.h
incubator/qpid/trunk/qpid/cpp/src/qpid/client/Channel.cpp
incubator/qpid/trunk/qpid/cpp/src/qpid/framing/AMQHeaderBody.cpp
incubator/qpid/trunk/qpid/cpp/src/qpid/io/APRSocket.cpp
incubator/qpid/trunk/qpid/cpp/src/qpid/io/BlockingAPRSessionContext.cpp
incubator/qpid/trunk/qpid/cpp/test/client/ (props changed)
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ExchangeTest.cpp
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/MessageTest.cpp
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/TopicExchangeTest.cpp
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ValueTest.cpp
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/FramingTest.cpp
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/HeaderTest.cpp
Propchange: incubator/qpid/trunk/qpid/cpp/
------------------------------------------------------------------------------
--- svn:ignore (original)
+++ svn:ignore Wed Oct 18 17:42:50 2006
@@ -1 +1,2 @@
qpidd.log
+gen
Modified: incubator/qpid/trunk/qpid/cpp/Makefile
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/Makefile?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/Makefile (original)
+++ incubator/qpid/trunk/qpid/cpp/Makefile Wed Oct 18 17:42:50 2006
@@ -44,7 +44,7 @@
.PHONY: test all all-nogen generate unittest pythontest
-test: all unittest pythontest
+test: unittest pythontest
# Must run this as two separate make processes to pick up generated files.
all:
@@ -81,21 +81,21 @@
# Client library.
CLIENT_LIB := lib/libqpid_client.so.1.0
CLIENT_SRC := $(wildcard src/qpid/client/*.cpp)
-$(CLIENT_LIB): $(CLIENT_SRC:.cpp=.o)
- $(LIB_CMD) $^ $(CURDIR)/$(COMMON_LIB)
+$(CLIENT_LIB): $(CLIENT_SRC:.cpp=.o) $(CURDIR)/$(COMMON_LIB)
+ $(LIB_CMD) $^
all-nogen: $(CLIENT_LIB)
UNITTESTS := $(UNITTESTS) $(wildcard $(COMMON_DIRS:%=test/unit/%/*Test.cpp))
# Broker library.
BROKER_LIB := lib/libqpid_broker.so.1.0
BROKER_SRC := $(wildcard src/qpid/broker/*.cpp)
-$(BROKER_LIB): $(BROKER_SRC:.cpp=.o)
- $(LIB_CMD) $^ $(CURDIR)/$(COMMON_LIB)
+$(BROKER_LIB): $(BROKER_SRC:.cpp=.o) $(CURDIR)/$(COMMON_LIB)
+ $(LIB_CMD) $^
all-nogen: $(BROKER_LIB)
UNITTESTS := $(UNITTESTS) $(wildcard test/unit/qpid/broker/*Test.cpp)
# Implicit rule for unit test plugin libraries.
-%Test.so: %Test.cpp
+%Test.so: %Test.cpp $(CURDIR)/$(COMMON_LIB) $(CURDIR)/$(BROKER_LIB)
$(CXX) -shared -o $@ $< $($(LIB)_FLAGS) -Itest/include $(CXXFLAGS)
$(LDFLAGS) -lapr-1 -lcppunit $(CURDIR)/$(COMMON_LIB) $(CURDIR)/$(BROKER_LIB)
## Client tests
@@ -106,16 +106,16 @@
## Daemon executable
-bin/qpidd: src/qpidd.o $(CURDIR)/$(COMMON_LIB)
- $(CXX) -o $@ $(CXXFLAGS) $(LDFLAGS) -lapr-1 $^ $(CURDIR)/$(BROKER_LIB)
+bin/qpidd: src/qpidd.o $(CURDIR)/$(COMMON_LIB) $(CURDIR)/$(BROKER_LIB)
+ $(CXX) -o $@ $(CXXFLAGS) $(LDFLAGS) -lapr-1 $^
all-nogen: bin/qpidd
## Run unit tests.
-unittest: $(UNITTESTS:.cpp=.so)
+unittest: all
DllPlugInTester -c -b $(UNITTESTS:.cpp=.so)
## Run python tests
-pythontest: bin/qpidd
+pythontest: all
bin/qpidd > qpidd.log &
cd ../python ; ./run-tests -v -I cpp_failing.txt
Modified: incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.cpp Wed
Oct 18 17:42:50 2006
@@ -48,14 +48,7 @@
framemax(65536),
heartbeat(0) {}
-SessionHandlerImpl::~SessionHandlerImpl(){
- // TODO aconway 2006-09-07: Should be auto_ptr or plain members.
- delete channelHandler;
- delete connectionHandler;
- delete basicHandler;
- delete exchangeHandler;
- delete queueHandler;
-}
+SessionHandlerImpl::~SessionHandlerImpl(){}
Channel* SessionHandlerImpl::getChannel(u_int16_t channel){
channel_iterator i = channels.find(channel);
Modified: incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.h
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.h?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.h
(original)
+++ incubator/qpid/trunk/qpid/cpp/src/qpid/broker/SessionHandlerImpl.h Wed Oct
18 17:42:50 2006
@@ -71,11 +71,11 @@
AutoDelete* const cleaner;
const u_int32_t timeout;//timeout for auto-deleted queues (in ms)
- ConnectionHandler* connectionHandler;
- ChannelHandler* channelHandler;
- BasicHandler* basicHandler;
- ExchangeHandler* exchangeHandler;
- QueueHandler* queueHandler;
+ std::auto_ptr<ConnectionHandler> connectionHandler;
+ std::auto_ptr<ChannelHandler> channelHandler;
+ std::auto_ptr<BasicHandler> basicHandler;
+ std::auto_ptr<ExchangeHandler> exchangeHandler;
+ std::auto_ptr<QueueHandler> queueHandler;
std::map<u_int16_t, Channel*> channels;
std::vector<Queue::shared_ptr> exclusiveQueues;
@@ -212,11 +212,11 @@
virtual ~BasicHandlerImpl(){}
};
- inline virtual ChannelHandler* getChannelHandler(){ return channelHandler;
}
- inline virtual ConnectionHandler* getConnectionHandler(){ return
connectionHandler; }
- inline virtual BasicHandler* getBasicHandler(){ return basicHandler; }
- inline virtual ExchangeHandler* getExchangeHandler(){ return
exchangeHandler; }
- inline virtual QueueHandler* getQueueHandler(){ return queueHandler; }
+ inline virtual ChannelHandler* getChannelHandler(){ return
channelHandler.get(); }
+ inline virtual ConnectionHandler* getConnectionHandler(){ return
connectionHandler.get(); }
+ inline virtual BasicHandler* getBasicHandler(){ return basicHandler.get();
}
+ inline virtual ExchangeHandler* getExchangeHandler(){ return
exchangeHandler.get(); }
+ inline virtual QueueHandler* getQueueHandler(){ return queueHandler.get();
}
inline virtual AccessHandler* getAccessHandler(){ return 0; }
inline virtual FileHandler* getFileHandler(){ return 0; }
Modified: incubator/qpid/trunk/qpid/cpp/src/qpid/client/Channel.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/src/qpid/client/Channel.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/src/qpid/client/Channel.cpp (original)
+++ incubator/qpid/trunk/qpid/cpp/src/qpid/client/Channel.cpp Wed Oct 18
17:42:50 2006
@@ -119,9 +119,7 @@
void Channel::bind(const Exchange& exchange, const Queue& queue, const
std::string& key, const FieldTable& args, bool synch){
string e = exchange.getName();
string q = queue.getName();
- // TODO aconway 2006-10-10: not const correct, get rid of const_cast.
- //
- AMQFrame* frame = new AMQFrame(id, new QueueBindBody(0, q, e, key,!synch,
const_cast<FieldTable&>(args)));
+ AMQFrame* frame = new AMQFrame(id, new QueueBindBody(0, q, e, key,!synch,
args));
if(synch){
sendAndReceive(frame, queue_bind_ok);
}else{
Modified: incubator/qpid/trunk/qpid/cpp/src/qpid/framing/AMQHeaderBody.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/src/qpid/framing/AMQHeaderBody.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/src/qpid/framing/AMQHeaderBody.cpp (original)
+++ incubator/qpid/trunk/qpid/cpp/src/qpid/framing/AMQHeaderBody.cpp Wed Oct 18
17:42:50 2006
@@ -63,11 +63,7 @@
{
out << "header, content_size=" << getContentSize()
<< " (" << size() << " bytes)" << ", headers=" ;
- // TODO aconway 2006-09-26: Hack to see headers.
- // Should write proper op << for BasicHeaderProperties.
- //
const BasicHeaderProperties* props =
dynamic_cast<const BasicHeaderProperties*>(getProperties());
- // TODO aconway 2006-09-26: Lose the static cast, fix BasicHeaderProperties
if (props) out << const_cast<BasicHeaderProperties*>(props)->getHeaders();
}
Modified: incubator/qpid/trunk/qpid/cpp/src/qpid/io/APRSocket.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/src/qpid/io/APRSocket.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/src/qpid/io/APRSocket.cpp (original)
+++ incubator/qpid/trunk/qpid/cpp/src/qpid/io/APRSocket.cpp Wed Oct 18 17:42:50
2006
@@ -45,7 +45,6 @@
do{
bytes = buffer.available();
apr_socket_send(socket, buffer.start(), &bytes);
- // TODO aconway 2006-10-05: why don't we check status here?
buffer.move(bytes);
}while(bytes > 0);
}
Modified:
incubator/qpid/trunk/qpid/cpp/src/qpid/io/BlockingAPRSessionContext.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/src/qpid/io/BlockingAPRSessionContext.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/src/qpid/io/BlockingAPRSessionContext.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/src/qpid/io/BlockingAPRSessionContext.cpp Wed
Oct 18 17:42:50 2006
@@ -122,8 +122,7 @@
int written = 0;
apr_size_t bytes = available;
while(available > written){
- apr_status_t s = apr_socket_send(socket, data + written,
&bytes);
- assert(s == 0); // TODO aconway 2006-10-05: Error Handling.
+ apr_socket_send(socket, data + written, &bytes);
written += bytes;
bytes = available - written;
}
Propchange: incubator/qpid/trunk/qpid/cpp/test/client/
------------------------------------------------------------------------------
--- svn:ignore (added)
+++ svn:ignore Wed Oct 18 17:42:50 2006
@@ -0,0 +1,3 @@
+client_test
+topic_listener
+topic_publisher
Modified: incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ExchangeTest.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ExchangeTest.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ExchangeTest.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ExchangeTest.cpp Wed
Oct 18 17:42:50 2006
@@ -34,8 +34,6 @@
public:
- // TODO aconway 2006-09-12: Need more detailed tests.
-
void testMe()
{
Queue::shared_ptr queue(new Queue("queue", true, true));
@@ -56,7 +54,6 @@
topic.route(msg, "abc", 0);
direct.route(msg, "abc", 0);
- // TODO aconway 2006-09-12: TODO Why no assertions?
}
};
Modified: incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/MessageTest.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/MessageTest.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/MessageTest.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/MessageTest.cpp Wed Oct
18 17:42:50 2006
@@ -32,9 +32,6 @@
public:
- // TODO aconway 2006-09-12: Need more detailed tests,
- // need tests to assert something!
- //
void testMe()
{
APRBase::increment();
Modified:
incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/TopicExchangeTest.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/TopicExchangeTest.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/TopicExchangeTest.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/TopicExchangeTest.cpp
Wed Oct 18 17:42:50 2006
@@ -17,8 +17,6 @@
#define TOKENS(a) makeTokens(a, a + LEN(a))
// Allow CPPUNIT_EQUALS to print a Tokens.
-// TODO aconway 2006-09-19: Make it a template and put it in a shared test lib.
-//
CppUnit::OStringStream& operator <<(CppUnit::OStringStream& out, const Tokens&
v)
{
out << "[ ";
Modified: incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ValueTest.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ValueTest.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ValueTest.cpp (original)
+++ incubator/qpid/trunk/qpid/cpp/test/unit/qpid/broker/ValueTest.cpp Wed Oct
18 17:42:50 2006
@@ -4,18 +4,6 @@
using namespace qpid::framing;
-// Allow CPPUNIT_EQUALS to print a Tokens.
-// TODO aconway 2006-09-19: Make it a template and put it in a shared test lib.
-//
-template <class T>
-CppUnit::OStringStream& operator <<(CppUnit::OStringStream& out,
- const ValueOps<T>& v)
-{
- out << v.getValue();
- return out;
-}
-
-
class ValueTest : public CppUnit::TestCase
{
CPPUNIT_TEST_SUITE(ValueTest);
Modified: incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/FramingTest.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/FramingTest.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/FramingTest.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/FramingTest.cpp Wed
Oct 18 17:42:50 2006
@@ -15,17 +15,15 @@
* limitations under the License.
*
*/
-#include "qpid/framing/amqp_framing.h"
#include "qpid/framing/ConnectionRedirectBody.h"
+#include "qpid/framing/amqp_framing.h"
#include <iostream>
-#include <sstream>
#include <qpid_test_plugin.h>
+#include <sstream>
#include <typeinfo>
using namespace qpid::framing;
-// TODO aconway 2006-09-12: Why do we need explicit qpid::framing:: below?
-
template <class T>
std::string tostring(const T& x)
{
@@ -42,8 +40,8 @@
CPPUNIT_TEST(testConnectionRedirectBody);
CPPUNIT_TEST(testAccessRequestBody);
CPPUNIT_TEST(testBasicConsumeBody);
- CPPUNIT_TEST(ConnectionRedirectBody);
- CPPUNIT_TEST(BasicConsumeOkBody);
+ CPPUNIT_TEST(testConnectionRedirectBodyFrame);
+ CPPUNIT_TEST(testBasicConsumeOkBodyFrame);
CPPUNIT_TEST_SUITE_END();
private:
@@ -78,10 +76,10 @@
{
std::string a = "hostA";
std::string b = "hostB";
- qpid::framing::ConnectionRedirectBody in(a, b);
+ ConnectionRedirectBody in(a, b);
in.encodeContent(buffer);
buffer.flip();
- qpid::framing::ConnectionRedirectBody out;
+ ConnectionRedirectBody out;
out.decodeContent(buffer);
CPPUNIT_ASSERT_EQUAL(tostring(in), tostring(out));
}
@@ -110,11 +108,11 @@
}
- void ConnectionRedirectBody()
+ void testConnectionRedirectBodyFrame()
{
std::string a = "hostA";
std::string b = "hostB";
- AMQFrame in(999, new qpid::framing::ConnectionRedirectBody(a, b));
+ AMQFrame in(999, new ConnectionRedirectBody(a, b));
in.encode(buffer);
buffer.flip();
AMQFrame out;
@@ -122,10 +120,10 @@
CPPUNIT_ASSERT_EQUAL(tostring(in), tostring(out));
}
- void BasicConsumeOkBody()
+ void testBasicConsumeOkBodyFrame()
{
std::string s = "hostA";
- AMQFrame in(999, new qpid::framing::BasicConsumeOkBody(s));
+ AMQFrame in(999, new BasicConsumeOkBody(s));
in.encode(buffer);
buffer.flip();
AMQFrame out;
Modified: incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/HeaderTest.cpp
URL:
http://svn.apache.org/viewvc/incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/HeaderTest.cpp?view=diff&rev=465432&r1=465431&r2=465432
==============================================================================
--- incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/HeaderTest.cpp
(original)
+++ incubator/qpid/trunk/qpid/cpp/test/unit/qpid/framing/HeaderTest.cpp Wed Oct
18 17:42:50 2006
@@ -31,9 +31,6 @@
public:
- // TODO aconway 2006-09-12: Need more detailed tests,
- // need tests to assert something!
- //
void testGenericProperties()
{
AMQHeaderBody body(BASIC);
