svn commit: r583548 - /incubator/qpid/branches/M2.1/java/systests/src/main/java/org/apache/qpid/test/framework/ExceptionMonitor.java

[ritchiem]

Author: ritchiem
Date: Wed Oct 10 10:15:59 2007
New Revision: 583548

URL: http://svn.apache.org/viewvc?rev=583548&view=rev
Log:
QPID-632 : The lack of AMQNoConsumersException on the connection may be due to 
the exception list in ExceptionMonitor not being thread safe. Synchronized 
method calls to ensure atomic access.

Modified:
    
incubator/qpid/branches/M2.1/java/systests/src/main/java/org/apache/qpid/test/framework/ExceptionMonitor.java

Modified: 
incubator/qpid/branches/M2.1/java/systests/src/main/java/org/apache/qpid/test/framework/ExceptionMonitor.java
URL: 
http://svn.apache.org/viewvc/incubator/qpid/branches/M2.1/java/systests/src/main/java/org/apache/qpid/test/framework/ExceptionMonitor.java?rev=583548&r1=583547&r2=583548&view=diff
==============================================================================
--- 
incubator/qpid/branches/M2.1/java/systests/src/main/java/org/apache/qpid/test/framework/ExceptionMonitor.java
 (original)
+++ 
incubator/qpid/branches/M2.1/java/systests/src/main/java/org/apache/qpid/test/framework/ExceptionMonitor.java
 Wed Oct 10 10:15:59 2007
@@ -52,7 +52,7 @@
      *
      * @param e The exception to record.
      */
-    public void onException(JMSException e)
+    public synchronized void onException(JMSException e)
     {
         log.debug("public void onException(JMSException e): called", e);
 
@@ -64,7 +64,7 @@
      *
      * @return <tt>true</tt> if no exceptions have been received, 
<tt>false</tt> otherwise.
      */
-    public boolean assertNoExceptions()
+    public synchronized boolean assertNoExceptions()
     {
         return exceptions.isEmpty();
     }
@@ -74,7 +74,7 @@
      *
      * @return <tt>true</tt> if exactly one exception been received, 
<tt>false</tt> otherwise.
      */
-    public boolean assertOneJMSException()
+    public synchronized boolean assertOneJMSException()
     {
         return exceptions.size() == 1;
     }
@@ -85,7 +85,7 @@
      * @return <tt>true</tt> if exactly one exception, with a linked cause of 
the specified type, been received,
      *         <tt>false</tt> otherwise.
      */
-    public boolean assertOneJMSExceptionWithLinkedCause(Class aClass)
+    public synchronized boolean assertOneJMSExceptionWithLinkedCause(Class 
aClass)
     {
         if (exceptions.size() == 1)
         {
@@ -107,7 +107,7 @@
      *
      * @return The number of exceptions held by this monitor.
      */
-    public int size()
+    public synchronized int size()
     {
         return exceptions.size();
     }
@@ -115,9 +115,9 @@
     /**
      * Clears the record of received exceptions.
      */
-    public void reset()
+    public synchronized void reset()
     {
-        exceptions = new ArrayList();
+        exceptions = new ArrayList<JMSException>();
     }
 
     /**
@@ -126,7 +126,7 @@
      *
      * @return A string containing a dump of the stack traces of all 
exceptions.
      */
-    public String toString()
+    public synchronized String toString()
     {
         String result = "ExceptionMonitor: holds " + exceptions.size() + " 
exceptions.\n\n";