On Oct 27, 2006, at 9:40 AM, Daniel Kulp wrote:
Steve,
On Thursday October 26 2006 4:29 pm, you wrote:
Is there a critical reason for the use of junit4 in the qpid tests?
The reason I ask is that maven2 and junit4 simply do not get along
just yet. Specifically, it's a known bug that the maven surefire
plugin doesn't handle junit4, and while a maven-junit workaround
plugin exists, it's rudimentary and so won't handle the tests qpid
has.
Just to let you know, I've talked to a few people on the Maven
teams and
made some comments on a thread on their dev list [1] and such and it
looks like we have commitment from them to have one person make the
surefire plugin their highest priority starting next week. I
don't know
if JUnit 4 [2] will make it or not. At the very least, if everyone
would vote for the "suite()" fix [3], that would at least allow the
workaround to work.
Dan, thanks for this info. I put in my vote, and encourage all other
Qpid team members to do likewise.
--steve
Dan
[1]http://mail-archives.apache.org/mod_mbox/maven-dev/200610.mbox/
<200610261715.43494.daniel.kulp%40iona.com>
[2]http://jira.codehaus.org/browse/SUREFIRE-31
[3]http://jira.codehaus.org/browse/MSUREFIRE-131
On my maven branch I've switched the broker subdir tests back to
junit3, and they seem to work OK. But before diving in and changing
other tests, I wanted to see if there's critical need for junit4 as
opposed to junit3 that I'm missing.
On a related note, in general, the qpid tests need some serious
reorganization, as it looks like unit tests, performance tests, and
system tests are all thrown together under the subdir test
directories. The common subdir has no tests or test subdir at all,
but at least it appears to be semi-tested by tests in other subdirs.
Also, as I've commented before, the unit tests aren't really unit
tests, but are instead really more like system tests. Maven gives us
a very nice standard directory structure that makes it clear which
tests belong where, so given the maven/junit issues and the need to
convert to junit3, I was going to tackle some of these issues on my
branch, but again, would like to get input from the Qpid community on
the above issue before continuing.
--steve
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194 F:781-902-8001
[EMAIL PROTECTED]
