Hi Martin, thanks for the detailed report. I already knew about most
of these, but made a decision to finally get some sleep rather than
try to fix it all up in the middle of the night. Everything you've
listed can and will be fixed relatively easily today.
On Nov 14, 2006, at 8:41 AM, Martin Ritchie wrote:
Qpid-developers,
There are still a few issues I've noted with using the mvn branch for
M1. Most of the issues are quite small but we need to start testing
and working on the rest of the release process without holding up M2
development.
Build:
- Mina jar is downloaded rather than using our existing snapshot.
Yes, and this is a good thing. If it works with a build provided by
the team, that's much better than us having to grab a particular svn
revision off the mina svn repository and build it for ourselves.
Both Distributions
- Top level License file doesn't reference or include all other
license files.
- Disclaimer content is wrong. (currently for CXF)
Yes, I hadn't gotten to the license stuff yet. It's easily included,
and the disclaimer is easily fixed.
Source Distribution
- AMQP Specification is not included so compilation cannot occur, see
mvn output at end of email.
This is partly due to the nature of the branch, as it's only a copy
of everything from the java level and below. Adding it is, again, easy.
- Should the source include sufficient files to be able to do a
release? or should it just be the project source files for
compilation.
I don't know the answer to that.
Binary Distribution
- Windows batch scripts no longer work as the <module>-launcher.jars
are not generated.
Rather than generating separate client and broker launcher jars,
there's one qpid-incubator.jar. The broker/etc/qpid-server.conf file
reflects the use of that jar, for example, and Windows scripts are
easily fixed. Perhaps this goes against the desire to allow clients
to be JDK 1.4, but as I mentioned in earlier emails, the client tests
use junit4 annotations and thus can't be compiled with 1.4 anyway,
which means that with maven that whole directory must be built with
1.5. The 1.4 thing is a red herring IMO.
Also, I don't think that those launcher jars can be named that way,
by Apache rules. I believe the term "incubator" or "incubating" has
to appear in there somewhere.
- META-INF directory in generated jars are missing
Disclaimer,License and Notes
Easily fixed.
- No JavaDoc in the doc folder
How useful is the javadoc? I started to add it but left it out for
now, since is provides no clear delineation of what is interface and
what is implementation. Simply javadoc'ing every class in the system
isn't that useful, IMO.
If you look at Tuscany, CXF, or Yoko, they build an API jar that
reflects the actual application interface, and generate javadoc from
that. I believe we should take a similar approach.
- Management module is missing
As is cluster -- I explicitly left them out, in the interest of
getting something to show in time. Adding them requires 3 more lines
in the pom and just a few lines in the assembly specifications.
Other issues
- Library naming, how do we do a Release rather than a snapshot?
By changing pom version numbers.
- Should we include an empty log directory in the binary build?
I know Steve has put a LOT of good work into getting maven
together. My
understanding of the M1 release was so we had baseline to support our
current clients.
The big white elephant in the room here is that some here seem to
want M1 to be a release of the ant-based status quo, while others
want M1 to include maven for a variety of reasons, not the least of
which is that it we believe it's the right way forward for the Qpid
development community, represents how we think releases ought to be
done, shows that we're quickly and properly learning Apache
guidelines and practices, and avoids doing the same work two or more
times, first in ant then in maven.
If an existing client takes a binary release created with maven, to
the best of my knowledge, the only thing that changes is the name of
the "launcher" jar, which as I explained above has to be renamed
anyway. So what else is it about the maven release that you think
won't support existing clients?
Is there any other issues that anyone else has noticed?
We still have the junit3 vs. junit4 issue, which we should answer ASAP.
--steve
--
Martin
Here is the error I get trying to do a mvn from the source release:
[INFO] Scanning for projects...
[INFO] Reactor build order:
[INFO] Qpid
[INFO] Qpid Common Utilities
[INFO] Qpid Broker
[INFO] Qpid Client
[INFO] Qpid Management
[INFO] Qpid Management Core
[INFO] Qpid Management Client
[INFO] Qpid Cluster
[INFO] Qpid System Tests
[INFO]
----------------------------------------------------------------------
------
[INFO] Building Qpid
[INFO] task-segment: [install]
[INFO]
----------------------------------------------------------------------
------
[INFO] [site:attach-descriptor]
[INFO] [install:install]
[INFO] Installing c:\dev\Apache
Projects\Qpid-Head\Qpid\branches\mvn\distribution\target\qpid-1.0-in
cubator-M1-SNAPSHOT-java-src\qpid-1.0-incubator-M1-SNAPSHOT-src
\pom.xml
to c:\.mvn\repository\org\ap
ache\qpid\qpid\1.0-incubator-M1-SNAPSHOT\qpid-1.0-incubator-M1-
SNAPSHOT.pom
[INFO]
----------------------------------------------------------------------
------
[INFO] Building Qpid Common Utilities
[INFO] task-segment: [install]
[INFO]
----------------------------------------------------------------------
------
[INFO] [antrun:run {execution: protocol-version}]
[INFO] Executing tasks
generate:
[mkdir] Created dir: C:\dev\Apache
Projects\Qpid-Head\Qpid\branches\mvn\distribution\target\qpid
-1.0-incubator-M1-SNAPSHOT-java-src\qpid-1.0-incubator-M1-SNAPSHOT-
src\common\target\generated\xsl\o
rg\apache\qpid\framing
[copy] Copying 1 file to C:\dev\Apache
Projects\Qpid-Head\Qpid\branches\mvn\distribution\target
\qpid-1.0-incubator-M1-SNAPSHOT-java-src\qpid-1.0-incubator-M1-
SNAPSHOT-src\common\target\generated\
xsl\org\apache\qpid\framing
[INFO]
----------------------------------------------------------------------
--
[ERROR] BUILD ERROR
[INFO]
----------------------------------------------------------------------
--
[INFO] Error executing ant tasks
Embedded error: The following error occurred while executing this
line:
C:\dev\Apache Projects\Qpid-Head\Qpid\branches\mvn\distribution
\target\qpid-1.0-incubator-M1-SNAPSHO
T-java-src\qpid-1.0-incubator-M1-SNAPSHOT-src\common\protocol-
version.xml:106:
The following error o
ccurred while executing this line:
C:\dev\Apache Projects\Qpid-Head\Qpid\branches\mvn\distribution
\target\qpid-1.0-incubator-M1-SNAPSHO
T-java-src\qpid-1.0-incubator-M1-SNAPSHOT-src\common\protocol-
version.xml:49:
ERROR: AMQP specificat
ion file ../../../trunk/qpid/specs/amqp-8.0.xml not found.
[INFO]
----------------------------------------------------------------------
--
[INFO] For more information, run Maven with the -e switch
[INFO]
----------------------------------------------------------------------
--
[INFO] Total time: 3 seconds
[INFO] Finished at: Tue Nov 14 08:40:19 GMT 2006
[INFO] Final Memory: 7M/14M
[INFO]
----------------------------------------------------------------------
--
On 14/11/06, Martin Ritchie <[EMAIL PROTECTED]> wrote:
There are still a few problems with the mvn distribution:
Both Distributions
-Top level License file doesn't reference or include all other
license files.
Source Distribution
- AMQP Specification is not included so compilation cannot occur, see
mvn output at end of email.
- Should the source include sufficient files to be able to do a
release? Should it not just be the project source files for
compilation.
Binary Distribution
- Windows batch scripts no longer work as the <module>-launcher.jars
are not generated.
- META-INF directory is missing Disclaimer,License and Notes
- Library naming, how do we do a Release rather than a snapshot?
There is quite a list of things that need to be resolved. I know
Steve
has put a LOT of good work into getting maven together. My
understanding of the M1 release was so we had baseline to support our
current clients.
Given that our current schedule is to do a M2 before Christmas
what is
the groups view?
[ ] Branch now for M1
[ ] Fix outstanding maven issues for M2 which is around 4 weeks
from now.
--
Martin
Here is the error I get trying to do a mvn from the source release:
[INFO] Scanning for projects...
[INFO] Reactor build order:
[INFO] Qpid
[INFO] Qpid Common Utilities
[INFO] Qpid Broker
[INFO] Qpid Client
[INFO] Qpid Management
[INFO] Qpid Management Core
[INFO] Qpid Management Client
[INFO] Qpid Cluster
[INFO] Qpid System Tests
[INFO]
---------------------------------------------------------------------
-------
[INFO] Building Qpid
[INFO] task-segment: [install]
[INFO]
---------------------------------------------------------------------
-------
[INFO] [site:attach-descriptor]
[INFO] [install:install]
[INFO] Installing c:\dev\Apache
Projects\Qpid-Head\Qpid\branches\mvn\distribution\target\qpid-1.0-in
cubator-M1-SNAPSHOT-java-src\qpid-1.0-incubator-M1-SNAPSHOT-src
\pom.xml
to c:\.mvn\repository\org\ap
ache\qpid\qpid\1.0-incubator-M1-SNAPSHOT\qpid-1.0-incubator-M1-
SNAPSHOT.pom
[INFO]
---------------------------------------------------------------------
-------
[INFO] Building Qpid Common Utilities
[INFO] task-segment: [install]
[INFO]
---------------------------------------------------------------------
-------
[INFO] [antrun:run {execution: protocol-version}]
[INFO] Executing tasks
generate:
[mkdir] Created dir: C:\dev\Apache
Projects\Qpid-Head\Qpid\branches\mvn\distribution\target\qpid
-1.0-incubator-M1-SNAPSHOT-java-src\qpid-1.0-incubator-M1-SNAPSHOT-
src\common\target\generated\xsl\o
rg\apache\qpid\framing
[copy] Copying 1 file to C:\dev\Apache
Projects\Qpid-Head\Qpid\branches\mvn\distribution\target
\qpid-1.0-incubator-M1-SNAPSHOT-java-src\qpid-1.0-incubator-M1-
SNAPSHOT-src\common\target\generated\
xsl\org\apache\qpid\framing
[INFO]
---------------------------------------------------------------------
---
[ERROR] BUILD ERROR
[INFO]
---------------------------------------------------------------------
---
[INFO] Error executing ant tasks
Embedded error: The following error occurred while executing this
line:
C:\dev\Apache Projects\Qpid-Head\Qpid\branches\mvn\distribution
\target\qpid-1.0-incubator-M1-SNAPSHO
T-java-src\qpid-1.0-incubator-M1-SNAPSHOT-src\common\protocol-
version.xml:106:
The following error o
ccurred while executing this line:
C:\dev\Apache Projects\Qpid-Head\Qpid\branches\mvn\distribution
\target\qpid-1.0-incubator-M1-SNAPSHO
T-java-src\qpid-1.0-incubator-M1-SNAPSHOT-src\common\protocol-
version.xml:49:
ERROR: AMQP specificat
ion file ../../../trunk/qpid/specs/amqp-8.0.xml not found.
[INFO]
---------------------------------------------------------------------
---
[INFO] For more information, run Maven with the -e switch
[INFO]
---------------------------------------------------------------------
---
[INFO] Total time: 3 seconds
[INFO] Finished at: Tue Nov 14 08:40:19 GMT 2006
[INFO] Final Memory: 7M/14M
[INFO]
---------------------------------------------------------------------
---
On 14/11/06, Robert Greig <[EMAIL PROTECTED]> wrote:
> On 13/11/06, Daniel Kulp <[EMAIL PROTECTED]> wrote:
> > > > Hi Martin, that's odd, since mina 1.0.0 exists under the
central
> > > > repository at http://repo1.maven.org/maven2:
> > > >
> > > > <http://repo1.maven.org/maven2/org/apache/mina/>
> > > >
> > > > Maybe you just hit a network glitch or something like that?
> > >
> > > I am seeing exactly the same problem - have tried a few
times. Is
> > > there any special configuration required?
>
> The problem was this:
>
> "Maven 2.0.4 and lower, doesn't support https and proxy so if
you're
> in that case (and you're in that case if you're behind a proxy
because
> java.net website uses https protocol) there is still a
workaround; use
> the following system properties when using maven :
>
> -Dhttps.proxyHost=[proxy] -Dhttps.proxyPort=[port]"
>
> This was resolved when the order was changed in the POM.
>
> RG
>
--
Martin Ritchie
--
Martin Ritchie
