On Thursday 07 December 2006 14:04, Steve Vinoski wrote:
> I recently emailed about build avoidance issues with the generated
> framing code under common. The way it's done means that it builds
> every single time through, and does nothing at all to try to avoid
> the build if the spec file hasn't changed.
>
> Rajith and I have now both independently run into more problems with
> this code: it won't work under Eclipse. The code is generated into
> directory names that contain spec version numbers (e.g., org/apache/
> qpid/framing_8_0), but the actual code itself is declared to reside
> in the org.apache.qpid.framing package. This is clearly a no-no, and
> Eclipse refuses to build it.
>
> So, anybody have an idea as to when we'll start using the new code
> generation approach? The code seems to have existed for weeks now,
> but to the best of my knowledge, nobody's stated any intent regarding
> making it part of the normal trunk build.
>
> Also, will this new code address the build avoidance issues and the
> Eclipse issues?
>
> I need to know, because I don't want to go off and fix issues with
> the current stuff if it's all about to be replaced. We have several
> people who want to use Eclipse for Qpid work, and they're currently
> blocked by this.
>
> --steve
I've included a patch below to fix that generation problem. There is still a
problem in the client tests with a .java file in the wrong directory. That
and 618 warnings if you use a "default" Eclipse workspace.
--
J. Daniel Kulp
Principal Engineer
IONA
P: 781-902-8727 C: 508-380-7194
[EMAIL PROTECTED]
Index: common/protocol-version.xml
===================================================================
--- common/protocol-version.xml (revision 483576)
+++ common/protocol-version.xml (working copy)
@@ -61,8 +61,8 @@
flags="s" byline="true"/>
<!-- Create directory; generate from specification file -->
- <mkdir
dir="[EMAIL PROTECTED](major)[EMAIL PROTECTED](minor)}"/>
- <saxon
out="[EMAIL PROTECTED](major)[EMAIL PROTECTED](minor)}/results.out"
+ <mkdir dir="${generated.dir}"/>
<[EMAIL PROTECTED](major)[EMAIL PROTECTED](minor)}"/-->
+ <saxon out="${generated.dir}/results.out"
src="${specs.dir}/[EMAIL PROTECTED]"
xsl="${spec.stylesheet}">
<arg value="[EMAIL PROTECTED](major)}"/>
@@ -70,14 +70,14 @@
<arg value="registry_name=MainRegistry"/>
</saxon>
<!-- -->
- <saxon
out="[EMAIL PROTECTED](major)[EMAIL PROTECTED](minor)}/cluster.out"
+ <saxon out="${generated.dir}/cluster.out"
src="${cluster.asl}"
xsl="${spec.stylesheet}">
<arg value="[EMAIL PROTECTED](major)}"/>
<arg value="[EMAIL PROTECTED](minor)}"/>
<arg value="registry_name=ClusterRegistry"/>
</saxon>
- <saxon
out="[EMAIL PROTECTED](major)[EMAIL PROTECTED](minor)}/registry.out"
+ <saxon out="${generated.dir}/registry.out"
src="${registry.template}"
xsl="${registry.stylesheet}">
<arg value="[EMAIL PROTECTED](major)}"/>
