Checked in update. Thanks to Andrew Stiticher for finding the problem, and to Jim Meyering for helping to fix it.
Kim On Fri, 2006-12-15 at 19:33 +0100, Jim Meyering wrote: > Kim van der Riet <[EMAIL PROTECTED]> wrote: > > I'll get to this later this afternoon. Thanks for the patch. > > > > There is a function to do this already in CppGenerator: setRef(), which > > changes both string and FieldTable to const &. A shorter (but > > equivalent) change would be: > > > > - sb.append(indent + (defineFlag ? > > fieldDomainPair[FIELD_DOMAIN] + " " : "") + > > + sb.append(indent + (defineFlag ? > > setRef(fieldDomainPair[FIELD_DOMAIN]) + " " : "") + > > Yes, that looks better, indeed :-) > I suppose it's ok to transform "FieldTable" as well as "string".
