On Mon, 2007-01-15 at 14:52 +0000, Andrew Stitcher wrote: > On Mon, 2007-01-15 at 09:42 -0500, Kim van der Riet wrote: > > On Mon, 2007-01-15 at 14:38 +0000, Gordon Sim wrote: > > > Prefix with the namespaces? e.g. qpid_broker_SessionHandlerFactoryImpl_? > > > > Unless we can turn up a well-defined standard or pattern, I think this > > is as good a suggestion as any. > > I think there are two natural solutions - > * Use the file system hierarchy > * Use the namespace hierarchy > > I think the namespace hierarchy gives a more robust solution so I'd > agree with this solution. We also need to use a scheme so that normal > variables can't accidentally get the same name, so putting something in > uppercase might be a good idea say: > > QPID_BROKER_SessionHandlerFactoryImpl > > or maybe use a double underscore at the end as we don't use that > anywhere else: > > qpid_broker_SessionHandlerFactoryImpl__ > > Andrew
I prefer the latter because the namespace portion matches the actual code namespace (case-wise) and because it looks neater - if code aesthetics is any measure to use in these matters... :-) Do we in fact use single trailing underscores anywhere in the C++? Kim
