On 24/01/07, Tomas Restrepo <[EMAIL PROTECTED]> wrote:
While looking over the code base for the C# client, I noticed that the ByteBuffer class in Qpid.Buffer looks like it's in need of some serious refactoring. For one thing, the class has tons of commented code (most from the original Java code, I guess), but it's a bunch of other things as well.
Yes, it was probably just copied across from the Java directly and made to work for the bits used by Qpid.
For example, there are methods named almost exactly the same with different signatures (some of which don't seem to make a sense to me): public int getUnsignedShort()
This is almost certainly redundant and should be removed.
I think definitely there's some opportunity there for improvement in the whole Qpid.Buffer project, but I'm not quite sure yet I understand how it all fits together. Any comments?
It's probably worth as a first step seeing how much of it is actually used, Some may have been copied across but is not really required. RG
