Hi Alan,
> > 1- When can we start actually making commits to the qpid tree?
> When you've written some code worth committing :)

:) Yeah, I was asking actually more specifically because something said that
while the account got created it might "take a while before permissions are
given to the subversion repository of the project". Hence my question :)

> The golden rule is: no tests failing after your commit. For C++
> http://cwiki.apache.org/qpid/qpid-c-documentation.html has some
> guidelines, likewise for Java though I'm not as familiar.

Ohh, that's a given and I've been careful to try to ensure it (and have
fixed a number that were failing). My question was more about things like:
Is it the norm to reference the JIRA issue id of the bug/feature being
committed in the commit message? And stuff like that.

> svnmerge.py is the way to go. Rupert answered this one in another mail.

Thanks to Rupert for the detailed explanation, it helps a lot!

> IMO the person who commits the change (for themselves or on behalf of a
> non-committer) should close the JIRA, that's what I do. Ideally they
> should have already assigned the JIRA to themselves.

Ahh, excellent, then I'll start doing that later today.


Tomas Restrepo
http://www.winterdom.com/weblog/




Reply via email to