On 15/06/07, Rupert Smith <[EMAIL PROTECTED]> wrote:
Before you start puzzling why on trunk and not on M2, I think
CommitRollbackTest.testSend2ThenRollback was commented out on M2. A crime to
which I confess...
Anyone know what the maven 2 property to allow the build to complete
succesfully despite test failures is? That would be a really handy one to
know.
Rupert
On 15/06/07, Gordon Sim <[EMAIL PROTECTED]> wrote:
>
> Martin Ritchie wrote:
> > Gordon, were these failures on M2 or trunk?
>
> Trunk only. I ran the build on M2 several (+5) times with no failures.
>
I've tidied up the test on M2 so will send it to trunk.The test was
fairly race condition related but raised an interesting JMS question.
I don't remember the spec in detail but when should a message be
classed as redelivered?
If a message is prefetched then purged from the prefetch due to
rollback is it redelivered? The 'client' hasn't see the message so
should it be redelivered? Correct ordering is certainly an issue and
marking it redelivered is probably a safe option. But I think in this
test case:
send 1,2 : receive 1 : rollback : receive
the messages that should arrive are 1 (re-delivered) and 2. The order
is not defined but message 2 hasn't been seen by the real client code.
The Qpid Client framework has seen it but I don't think that counts.
Currently the code allows for message 2 to arrive twice as long as the
redelivered flag is true on one and false on the other.
--
Martin Ritchie
