Specifically we've been asked *not* to include log4j or such dependencies in the client library... If anything, if we ship with a default slf4j binding then it should be to the java logging API, not to log4j. What I agree does need to improve is the documentation around this
-- Rob On 06/07/07, Rupert Smith <[EMAIL PROTECTED]> wrote:
I guess because if its provided as part of the distribution, it will be in the pom as a transitive dependency of that distribution. Anyone depending on the distribution will pick up our choice of default. Not the end of the world, you could do it that way if you like. Rupert On 06/07/07, Jonathan Robie <[EMAIL PROTECTED]> wrote: > > I can easily see why you want to permit any slf4j implementation. > > I'm less clear on why you don't want any slf4j implementation to be > distributed as part of the client distribution. A user who doesn't > particularly want to provide an slf4j implementation would just like > something that works without thinking too hard. > > Jonathan > > Rupert Smith wrote: > > The client only depends on the API part of slf4j. To use it, you have to > > provide the slf4j implementation part that you want to use. > > > > For example, the client tests depend on slf4j-log4j: > > > > <dependency> > > <groupId>org.slf4j</groupId> > > <artifactId>slf4j-log4j12</artifactId> > > <version>1.4.0</version> > > <scope>test</scope> > > </dependency> > > > > > > However, we don't want to make the client itself depend on log4j, or > else > > that forces everyone who uses it to use log4j, which is the entire > > point of > > using slf4j. > > > > So if you have a project (MyProject), that wants to use the java > > client, use > > the following dependencies: > > > > MyProject depends on: > > -> Qpid Java Client > > -> slf4j implementation (e.g. slf4j-log4j12) > > > > Rupert > > > > On 06/07/07, Jonathan Robie <[EMAIL PROTECTED]> wrote: > >> > >> Is there supposed to be a client-only distribution of the Java AMQP > >> implementation? > >> > >> Maven is set up to build one. When I do, it doesn't work because it has > >> only the API files for slf4j. Here are the slf4j files in the full > >> distribution: > >> > >> [EMAIL PROTECTED] lib]$ pwd > >> /home/jrobie/project/qpid/java/distribution/target/qpid- > >> 1.0-incubating-M2-SNAPSHOT-java-bin/qpid-1.0-incubating-M2-SNAPSHOT /lib > >> [EMAIL PROTECTED] lib]$ ls slf4j* > >> slf4j-api-1.4.0.jar slf4j-jdk14-1.4.0.jar slf4j-nop-1.4.0.jar > >> slf4j-jcl-1.4.0.jar slf4j-log4j12-1.4.0.jar slf4j-simple-1.4.0.jar > >> [EMAIL PROTECTED] lib]$ > >> > >> > >> Here are the slf4j files in the client distribution: > >> > >> [EMAIL PROTECTED] lib]$ pwd > >> /home/jrobie/project/qpid/java/client/distribution/target/qpid- > >> 1.0-incubating-M2-SNAPSHOT-java-client-bin/qpid- > 1.0-incubating-M2-SNAPSHOT > >> > >> /lib > >> [EMAIL PROTECTED] lib]$ ls slf4j* > >> slf4j-api-1.4.0.jar > >> > >> Both distributions are newly built. > >> > >> Jonathan > >> > >> > >> > > > >
