On Thu, 2007-09-27 at 08:31 -0400, Rajith Attapattu wrote: > > On 9/27/07, Arnaud Simon <[EMAIL PROTECTED]> wrote: > On Thu, 2007-09-27 at 10:20 +0100, Rupert Smith wrote: > > Integration tests and client unit tests are quite > dissimilar. > > > > The integration tests are aimed at interop. The client unit > tests are > > supposed to be pure unit tests for the client, but in fact > they are > > more like Java client + broker sys tests. > > This is the issue, the client unit tests are not pure unit > tests for the > client but more client+broker tests. Some of them are even > more broker > oriented. > > Can we limit the tests in broker and client to be strictly unit tests > only. > i.e they only tests functions/methods in isolation.
> This will flag if we break any existing functionality and encourage > people to write proper unit tests as an when they write code. > > If we run a code coverage tool, we can clearly see that most of the > code is not tested in this way. > > As Arnaud said, we can try to move the current tests into integration > (or the systests if thats more acceptable) and consolidate them in one > place. > Then modify them to run against an in-vm broker or an external broker. > As part of the maven build we can run the in-vm broker. This is what we have decided (I think). But we will do the move later as it would currently complicate the M2 merge.