Carl,

This is a good idea. I'll update the schema so that there are cluster-specific extensions that are used only if the cluster plug-in is plugged in.

-Ted

Carl Trieloff wrote:

Ted,

Few comments/ thoughts on the patch - which is applied. I see from the CLI that methods for join and leave cluster are present even if the cluster module is not loaded. We should probably update the encapsulation so that the cluster module add's it's own data/ commands to the model if loaded.

The same should be true for any other plug-in that us loaded.
Carl.



Ted Ross (JIRA) wrote:
     [ 
https://issues.apache.org/jira/browse/QPID-715?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Ted Ross updated QPID-715:
--------------------------

    Attachment: qpid-patch14.diff

patch file

Management improvements for C++ Broker, Python API, and Python CLI
------------------------------------------------------------------

                Key: QPID-715
                URL: https://issues.apache.org/jira/browse/QPID-715
            Project: Qpid
         Issue Type: Improvement
         Components: C++ Broker, Python Client
        Environment: all
           Reporter: Ted Ross
           Priority: Minor
        Attachments: qpid-patch14.diff


This patch provides improvements in the management CLI and brings the 
implementation of the broker and the python management client into compliance 
with the draft spec 
(http://cwiki.apache.org/confluence/display/qpid/Management+Design+notes).
Per-file notes:
M  python/qpid/management.py
M  cpp/src/qpid/management/ManagementAgent.h
M  cpp/src/qpid/management/ManagementAgent.cpp
M  cpp/src/qpid/management/ManagementExchange.h
M  cpp/src/qpid/management/ManagementObject.h
M  specs/management-types.xml
   Added support for new management types.
   Updated protocol to comply with draft spec in the wiki.
M  python/mgmt-cli/main.py
M  python/mgmt-cli/managementdata.py
   Lots of enhanced CLI functionality
M  cpp/src/qpid/broker/Broker.h
M  cpp/src/qpid/broker/Broker.cpp
   Added method to get the VHost object, added call to shutdown the
   management agent when the broker is destroyed.
M  cpp/src/qpid/broker/Queue.cpp
   Removed IncreaseJournalSize method (not relevant to QPID)
M  cpp/src/qpid/broker/Connection.h
M  cpp/src/qpid/broker/Connection.cpp
M  cpp/src/qpid/broker/ConnectionFactory.h
M  cpp/src/qpid/broker/ConnectionFactory.cpp
M  cpp/src/qpid/sys/ConnectionInputHandlerFactory.h
M  cpp/src/qpid/sys/AsynchIOAcceptor.cpp
   Added management for Connections (Client management class).  The
   socket is now passed to the Connection object so access can be had
   to the remote IP-address and port.
M  cpp/src/qpid/broker/SessionState.cpp
M  cpp/src/qpid/broker/SessionManager.cpp
M  cpp/src/qpid/broker/SessionState.h
   Added management for SessionState (Session management class).
M  cpp/managementgen/main.py
   Makefile fragment generation is now optional.
M  specs/management-schema.xml
   Schema updates for Client and Session.


Reply via email to