folks, I see two minor issues with the AMQBindingURL and AMQDestination The binding URL is defined as follows. <exch_class>://<exch_name>/[<destination>]/[<queue>]?<option>='<value>'[,<option>='<value>']* RoutingKey is given as a valid option (See BindingURL class).
Then in AMQDestination we see that the constructors has a field called "destinationName" (in addition to exchangeName). As per the AMQP spec, destination refers to the exchange you are publishing. Therefore the binding url format is incorrect, as destination has no meaning there. It cannot be the routing_key as it is given as a valid option. So I propose we get rid of it. However the documentation here is correct, but sadly not reflected in the code properly. http://cwiki.apache.org/qpid/bindingurlformat.html Also in AMQDestination, destinationName is used as the routingKey which is creating confusion and it is also semantically wrong. The field destinationName should refer to the exchange we are publishing. But we already have a field named "exchangeName". So I renamed the field destination to routingKey and modified the code accordingly in both AMQQueue and AMQTopic. -- Regards, Rajith Attapattu Red Hat blog: http://rajith.2rlabs.com/
