[
https://issues.apache.org/jira/browse/QPID-594?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12572072#action_12572072
]
Martin Ritchie commented on QPID-594:
-------------------------------------
I'm getting a race condition on this fix. From head of M2.1
-------------------------------------------------------------------------------
Test set: org.apache.qpid.test.unit.client.connection.ConnectionTest
-------------------------------------------------------------------------------
Tests run: 8, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 1.265 sec <<<
FAILURE!
testPasswordFailureConnection(org.apache.qpid.test.unit.client.connection.ConnectionTest)
Time elapsed: 0.016
sec <<< FAILURE!
junit.framework.AssertionFailedError: Exception was wrong type expected:<class
javax.jms.JMSException> but was
:<class java.lang.Exception>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at
org.apache.qpid.test.unit.client.connection.ConnectionTest.testPasswordFailureConnection(Connection
Test.java:129)
It doesn't occur very often however it seems to affects SimpleACLTest on most
mvn runs:
-------------------------------------------------------------------------------
Test set: org.apache.qpid.server.security.acl.SimpleACLTest
-------------------------------------------------------------------------------
Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3.344 sec <<<
FAILURE!
testAccessNoRights(org.apache.qpid.server.security.acl.SimpleACLTest) Time
elapsed: 0.141 sec <<< FAILURE!
junit.framework.AssertionFailedError: Linked Exception Incorrect
expected:<class javax.jms.JMSException> but w
as:<class java.lang.Exception>
at junit.framework.Assert.fail(Assert.java:47)
at junit.framework.Assert.failNotEquals(Assert.java:282)
at junit.framework.Assert.assertEquals(Assert.java:64)
at
org.apache.qpid.server.security.acl.SimpleACLTest.testAccessNoRights(SimpleACLTest.java:116)
> Java client does not throw exceptions for failures during connection
> establishment
> ----------------------------------------------------------------------------------
>
> Key: QPID-594
> URL: https://issues.apache.org/jira/browse/QPID-594
> Project: Qpid
> Issue Type: Bug
> Components: Java Client
> Affects Versions: M2
> Environment: Any
> Reporter: Robert Greig
> Assignee: Aidan Skinner
> Priority: Critical
> Fix For: M2.1
>
> Time Spent: 2h
> Remaining Estimate: 0h
>
> The client does not deal with errors during connection establishment properly.
> For example, if the user tries to connect to an invalid virtual host an
> exception should be thrown in the ConnectionFactory.createConnection method.
> This does not happen.
> It appears that the exceptions are routed to the connection's exception
> listener which of course is useless when the connection has not been
> established. There are also issues with how this interacts with failover.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
