[ 
https://issues.apache.org/jira/browse/QPID-922?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Rob Godfrey resolved QPID-922.
------------------------------

    Resolution: Fixed

Committed fix onto M2.1 (soon to be M2.x) branch as revision 648637.

Following files changed:

broker/src/main/java/org/apache/qpid/server/filter/ComparisonExpression.java 

   added code to deal with AMQShortString / String comparisons
   updating ConstantExpressions to AMQShortString if they are compared to 
PropertyExpressions

broker/src/main/java/org/apache/qpid/server/filter/ConstantExpression.java

   added setter for value so that it can be modified by ComparisonExpression 
9see above)

broker/src/main/java/org/apache/qpid/server/filter/JMSSelectorFilter.java

   Fixed logging from info to debug level

broker/src/main/java/org/apache/qpid/server/filter/PropertyExpression.java

   Made properties return AMQShortString not String


> [Java Broker] Selectors comparing header properties to constants always 
> convert the property from AMQShortString to String, rather than converting 
> the constant once
> --------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: QPID-922
>                 URL: https://issues.apache.org/jira/browse/QPID-922
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker
>    Affects Versions: M2.1
>            Reporter: Rob Godfrey
>            Assignee: Rob Godfrey
>            Priority: Minor
>   Original Estimate: 4h
>  Remaining Estimate: 4h
>
> When using selectors against a header property (e.g. correlationId) the 
> selector evaluates the property of the message against a constant; due to the 
> type mismatch between AMQShortString and String a conversion occurs for every 
> message.  Instead we can convert the constant and cache the result.  This has 
> a performance improvement when running high volumes of transient messages 
> through selectors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to