The C++ examples contain some typos and other mistakes that will confuse users. 
These are usability errors
----------------------------------------------------------------------------------------------------------

                 Key: QPID-1051
                 URL: https://issues.apache.org/jira/browse/QPID-1051
             Project: Qpid
          Issue Type: Bug
          Components: C++ Client
         Environment: n/a   but Fedora 8 on a Thinkpad T61
            Reporter: William Henry
            Priority: Minor


There are a few residual usability errors that seem to be the result of copying 
examples over and not cleaning up. None of these bugs stop the code from 
compiling or running but would cause usability problems for new users that are 
looking at the examples as templates on how to use qpid.

E.g.

Several files declare unused Message instances:

Message message;

Some files headers contain erroneous information. Either mentioning 
non-existent files or using incorrect names.

I will attach some diff files that show the bugs in the code.

request_response/server.cpp  - declares a Message instance called message but 
doesn't use it.
pub-sub/topic_listener.cpp = mentions  topic_config_queues.cpp in the header 
but there is no such file.
pub-sub/topic_publisher.cpp = mentions  topic_config_queues.cpp in the header 
but there is no such file. Message is declared and unused.
fanout/listener.cpp - minor typo 'fro' for 'from' in header and Message 
declared and unused
fanout/producer.cpp -  declare_queues.cpp mentioned in header and Message 
declared twice. One in try block is used.
direct/declare_queues.cpp - named incorrectly as define_config_queues.cpp in 
header. Message declared and unused
direct/lisener.cpp- minor typo 'fro'  for 'from' in header . Message declared 
and unused




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to