Hi Robert,
So the first requirement is met. I got,
log4j:WARN Fatal parsing error 22 and column 30
log4j:WARN Attribute name "log4j:configuration" associated with an element
type "DOCTYPE" must be followed by the ' = ' character.
log4j:ERROR Could not parse file
[/home/senaka/qpid/java/distribution/target/qpid-1.0-incubating-M3-SNAPSHOT/etc/log4j.xml].
org.xml.sax.SAXParseException: Attribute name "log4j:configuration"
associated with an element type "DOCTYPE" must be followed by the ' = '
character.
at
com.sun.org.apache.xerces.internal.parsers.DOMParser.parse(DOMParser.java:239)
at
com.sun.org.apache.xerces.internal.jaxp.DocumentBuilderImpl.parse(DocumentBuilderImpl.java:283)
at javax.xml.parsers.DocumentBuilder.parse(DocumentBuilder.java:208)
at
org.apache.log4j.xml.DOMConfigurator$1.parse(DOMConfigurator.java:598)
at
org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigurator.java:711)
at
org.apache.log4j.xml.DOMConfigurator.doConfigure(DOMConfigurator.java:604)
at org.apache.log4j.xml.XMLWatchdog.doOnChange(DOMConfigurator.java:861)
at
org.apache.log4j.helpers.FileWatchdog.checkAndConfigure(FileWatchdog.java:88)
at org.apache.log4j.helpers.FileWatchdog.run(FileWatchdog.java:107)
This is my thought on continuing the polling mechanism. When we read the
log4j.xml at startup, if this issue is likely to crop-up we should initiate
a controlled shutdown after logging the warning. If, this happens during
operation the warning must be logged once, and we will continue with the
previous known values. The polling will continue as usual. Warnings on
subsequent failures will only fill the log, and thus will be disabled using
a property. If the error is corrected, this property that withheld the
warning will be reset and, a debug message will be logged explaining that
the problem was corrected.
Regards,
Senaka
On Tue, May 20, 2008 at 1:33 AM, Robert Greig <[EMAIL PROTECTED]>
wrote:
> 2008/5/19 Senaka Fernando <[EMAIL PROTECTED]>:
>
> > What I would like to know is whether this was intentional or
> un-intentional,
> > so that if it was un-intentional, I would like to work on a fix for this
> > issue. Your openion is greatly appreciated.
>
> Er no, it's not intentional. I think that a fatal level warning should
> be printed, and if possible the polling mechanism should continue so
> that a fixed file can be picked up.
>
> If for some reason it is not possible to keep polling for changes, the
> broker should initiate a controlled shutdown.
>
> RG
>
