On Fri, 2008-06-27 at 08:47 -0400, Rafael Schloming wrote: > Aidan Skinner wrote: > > On Fri, Jun 27, 2008 at 8:38 AM, Marnie McCormack > > <[EMAIL PROTECTED]> wrote: > > > >> I'm coming around to the view that we need to do this work very carefully, > >> and I'm not sure that needing message publication to trigger flow control > >> on > >> a producer is ideal. Been looking at the Active MQ producer window size and > >> wonder if we can't use a similar approach ? > > > > It's definately not ideal, the window size stuff is, AFAICT, quite > > similar to how 0-10 works but I don't think we can implement that with > > 0-8/0-9. :( > > One option you have on 0-8/0-9 is to stop reading from the socket. This > should cause the TCP window to fill up, and the client will eventually > block (or run out of memory because it's stupid enough to buffer > indefinitely). > > Something like this should allow you to do more sophisticated > rate-limiting type things in addition to just a binary on/off. > > Of course this sort of thing is probably easier said than done given > that we use the worlds Most Irritating Network Api. ;) > > --Rafael\
I added some comments to the Jira about the existing AMQP flow control and the stop-reading-sockets approach.
