On Fri, 2008-06-27 at 11:28 -0400, Andrew Stitcher wrote: > On Fri, 2008-06-27 at 14:05 +0200, Manuel Teira wrote: > > ... > > class AsynchConnector : > > //Bug http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6710638 > > //Should be private inheritance > > #ifdef __SUNPRO_CC > > public > > #else > > private > > #endif > > DispatchHandle { > > public: > > ... > > > > I must say I find this terribly ugly, but I suppose it does point out > the cause of the change.
It is ugly but I can't think of any less-ugly fix that preserves the private inheritance on non-Sun platforms. > So take out the #include "config.h" stuff and just include "string.h" > directly. At very worst it can't cause problems on Linux. > > There are very few cases now where you need to do conditional includes > along these lines. And in those cases the conditional includes should be isolated in a qpid/sys header file defining an abstraction that can be implemented differently on different platforms.
