2008/8/14 Robert Godfrey <[EMAIL PROTECTED]>: >> >> Potential patch conflicts are less of a problem from my PoV than >> having a ton of Jiras and commits that haven't gotten past the "ready >> for review" stage because people are inherently lazy and it's easier >> to not do it. > > But the likelihood is that instead you'd get a load of JIRAs with > patches on that no-one reviews because they are lazy :-) > > I think that if we as a group are good at enforcing the review phase > then we should be able to make this process workable. Producing > automated reports for number of unreviewed commits - plus a summary of > how many reviews each developer has done in the past month should I > think be sufficient to keep the number of unreviewed changes down to a > minimum.
I agree with the above. I have always found patch files a total PITA, and in any case the review process is about discipline. We should allow people to commit and try to manage the reviews through reporting and nudging. Reviewing commits will also reduce the time for the reviewer I think, which streamlines the process. If we had a different SCM tool then maybe we would do it differently. As another aside I see that svn 1.5.x does improve the merging capabilities so maybe at last things will get better with that tool. RG
