+1. For large/complex code changes I think its best to open a JIRA and start a discussion by posting a patch. But for 90% of the commits I think the above process makes sense.
Regards, Rajith On Wed, Aug 20, 2008 at 11:52 AM, Arnaud Simon <[EMAIL PROTECTED]> wrote: > +1 > > On Wed, 2008-08-20 at 16:07 +0100, Aidan Skinner wrote: > > Hi javaroos, > > > > I'd like to get a vote on doing formal reviews for everything under > > qpid/java that works like this (what we shall call the RG1 process as > > I cut n paste this from his mail): > > > > 1) work on issue and commit changes > > 2) mail or IM someone asking if he would mind reviewing it > > 3) assign issue to person doing review and move on until issue is > > either reopened by reviewer or resolved (or whatever state comes next) > > 4) run jira report regularly of issues in "pending review" state with > > no activity for 5 days. For those issues go back to step (2) with > > alternative reviewer if necessary. > > > > if there's consensus around this, I'd ideally like to start this on > > Monday, making this Friday our last big group slog. > > > > - Aidan > > -- Regards, Rajith Attapattu Red Hat http://rajith.2rlabs.com/
