[ 
https://issues.apache.org/jira/browse/QPID-1167?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Aidan Skinner resolved QPID-1167.
---------------------------------

    Resolution: Fixed

> Queue alerting nolonger works.
> ------------------------------
>
>                 Key: QPID-1167
>                 URL: https://issues.apache.org/jira/browse/QPID-1167
>             Project: Qpid
>          Issue Type: Bug
>          Components: Java Broker
>    Affects Versions: M2.1
>            Reporter: Martin Ritchie
>            Assignee: Aidan Skinner
>            Priority: Blocker
>             Fix For: M3
>
>
> Summary:
> This was broken by commit:
> #629731       Thu Feb 21 02:09:03 PST 2008    rgodfrey
> The update to AMQQueue to create a list active of NotificationChecks is fine 
> as a performance enhancement the problem is that on creation all alerts are 0 
> which means that no NotificationChecks are registered. 
> In some places the AMQQueue creation is followed by 
> Configurator.configure(...); however this does not call the set Methods but 
> directly changes the variables so the NotificationCheck registrations are 
> still missing.
> The virtualhost has a getConfiguredObject() which should be used to ensure 
> all object creations are correctly configured with the commons Configuration 
> values. However all configured objects will also need an init()  method as we 
> cannot use the constructor for things such as registering checks based on 
> configurable values. These values are not set until later (the 
> Configurator.configure(...) call to be exact.) 
> Changes Required:
> - All Configurable object creations need to be checked to ensure that the 
> object is correctly configured based on the commons.Configuration.
> - For consistency all Configurable objects should have an init() method to 
> perform any final setup after the configured values have been set.
> Testing:
> This needs additional testing. In particular the configuration values for 
> alerting need to be set via a real configuration not via the 
> set<Notification>() methods.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to